[Versioning] Migrate Hydra entry points to version_base 1.3 for Hydra 1.4 readiness - #4056
[Versioning] Migrate Hydra entry points to version_base 1.3 for Hydra 1.4 readiness#4056theap06 wants to merge 2 commits into
Conversation
… 1.4 readiness Hydra 1.4 will stop accepting version_base values below 1.3 (see pytorch#4055 and facebookresearch/hydra#3237). Migrate all entry points ahead of the release: - Replace version_base=1.1 with 1.3 in 57 hydra.main entry points and the compose-API calls in test_helpers.py and test_configs.py. - Replace version_base=None with 1.3 in the four LLM scripts (grpo and expert-iteration). Removing the argument, as suggested upstream, would emit a warning and flip back to 1.1-compat behavior on hydra 1.3.x, which remains the supported floor. - Add version_base=1.3 to five decorators that omitted it (gail, iql, td3_bc); these previously warned on every run. - Set hydra.job.chdir: true in the 53 primary configs of scripts that ran under 1.1 compat, preserving their run-directory behavior exactly. - Raise the hydra-core floor to >=1.3 in pyproject.toml. Verified with a synthetic hydra app under warnings-as-errors on both hydra-core 1.3.2-line stable and 1.4.0.dev6 with omegaconf 2.4.0.dev14: config composition, chdir into the run dir, and hydra-node stripping all behave identically.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4056
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Thanks for putting this together. The migration is broadly consistent: all 57 One item to address is propagating the
In an existing environment, an unconstrained requirement can leave Hydra 1.1 installed. The new One broader, non-blocking observation: needing to repeat There is also a broader compatibility choice to make. The new requirement is I suggest choosing one of these approaches:
The current state—allowing Hydra 1.4 without testing it—leaves users exposed to incompatibilities outside the scope of |
Hydra 1.4 is not yet finalized and TorchRL's compatibility with it has not been validated. Constrain hydra-core to >=1.3,<1.4 so that the version_base=1.3 migration in this PR is exercised against a known-good Hydra, rather than against a moving pre-release target. The ceiling is temporary: remove it once Hydra 1.4 is sufficiently finalized and TorchRL has been validated against it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
@omry I just temporarily constrained the dep for now. once the 1.4 is finalized and the trl compability has been validated, I will draft a follow up pr for the updated dep. |
Prepares Hydra entry points for Hydra 1.4 (#4055)
hydra.mainentry points and compose-API test calls now passversion_base="1.3"(previously"1.1",None, or unset).hydra.job.chdir: true, keeping run-dir behavior unchanged.>=1.3in pyproject.toml.Draft until Hydra 1.4 is released.