Repository navigation
Conversation
Fix bioclimatic local
Deletes the hand-copied pyoverkiz/ directory (was shadowing the real pip dependency already declared in requirements.txt) and migrates all call sites to the current published API: - OverkizClient now takes keyword-only credentials=/server= built from UsernamePasswordCredentials/LocalTokenCredentials and ServerConfig - Command is attrs kw_only=True, so all constructions need name=/parameters= - execute_command -> execute_action_group(actions=[Action(...)]) - execute_scenario -> execute_persisted_action_group - cancel_command -> cancel_execution - get_scenarios -> get_action_groups, Scenario -> PersistedActionGroup - Device.id -> Device.device_url, Gateway.id -> Gateway.gateway_id - NotAuthenticatedException -> NotAuthenticatedError Also pins pyoverkiz==2.1.0 in both requirements files and adds .github/dependabot.yml (pip, weekly) to track future releases. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
pyoverkiz>=2.0 requires Python >=3.12, so 3.11 can never install the real dependency. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Fix pyoverkiz
fix readme to point to relative path of the file instead of absolute …
|
Hello @mikopp, Thank you for the substantial work on this pull request. Your improvements — local API support, CI/CD automation, pyoverkiz refactoring — are clearly valuable. A note on collaboration: I am not experienced with collaborative pull request workflows. Auditing your 12 commits thoroughly is beyond my capacity right now, and I prefer to preserve the current codebase as-is (v3.0.3) without potential risks of regression or corruption. Suggestions for continuation: You may consider creating your own repository with a new name, such as:
It would also be helpful to clearly indicate in your README that this project is a fork of tahoma by pzim-devdata, to maintain attribution and give users context about its origins. Additionally, you might explore publishing your own package on PyPI (for example My commitment to you: If you proceed with this approach, I would be willing to:
This arrangement could benefit everyone:
Please feel free to let me know if this direction works for you, or share any other ideas you may have. Best regards, |
|
here is what I could post on my README : Tahoma CLI - Command Line Interface for Somfy Tahoma🔗 Actively Maintained ForkThis project (v3.0.3) remains functional and available. For active development, bug fixes, and new features, you may wish to explore: → tahoma-reborn by @mikopp (link pending)(Note: This project is a fork of taHoma by pzim-devdata) Also available on PyPI: |
|
hi @pzim-devdata , Thank you for the offer, but I won't be a regular user of this program, as I mostly use overkiz via home assistant. I really just did this because I wanted to access some manufacture data. So I would be willing to break smaller things out of this if you want to accept them, but I don't really intend to be a maintainer for this. the actual changes are not that big to be honest
the ci tests were really to ensure things don't break when somebody opens a pr - so to make the review burden lighter. So if you want any of that, tell me, otherwise I am ok if you close the PR ;). |
|
Hello @mikopp, Thank you for your transparency — I appreciate it. My position: I don't have time right now to dedicate to modifying and publishing a new version of taHoma CLI. This means:
What I will do:
What you may do:
Bottom line: No action needed from either of us right now. The PR stays open without pressure. If the situation evolves in the future, we can revisit. On the CLAUDE.md file you created: It's an interesting choice — this file guides Claude Code specifically during development. If you'd like broader AI discoverability across all language models, you could also add a Thanks again for your effort and understanding. Best regards, |
This pull request introduces several improvements to the project, focusing on CI/CD automation, dependency management, documentation, and some codebase refactoring. The main highlights are the addition of GitHub Actions for automated testing, Dependabot for dependency updates, expanded documentation, and code cleanup in
get_devices_url.py.** Direct new features **
CI/CD and Dependency Management:
.github/workflows/ci.yml) to automatically run linting and unit tests with multiple Python versions on pull requests and pushes tomain..github/dependabot.yml) to enable weekly checks for pip dependency updates.Documentation Improvements:
CLAUDE.mdfile explaining the project structure, device categories, local vs. cloud API usage, and recommended testing workflow.README.mdandREADME_FR.mdto use relative paths, improving portability for forks and mirrors.Codebase Refactoring and Cleanup:
get_devices_url.pyby removing unused imports, switching to a newtahoma_configfor configuration loading, and cleaning up legacy code related to server selection.