Skip to content

Feature/storage provider architecture - #107

Merged
sven1103 merged 34 commits into
mainfrom
feature/storage-provider-architecture
Sep 1, 2026
Merged

Feature/storage provider architecture#107
sven1103 merged 34 commits into
mainfrom
feature/storage-provider-architecture

Remove legacy V1 controller, promote V2 to MeasurementFileController

83e8103
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Sep 1, 2026 in 19s

Quality Gate passed

Issues
23 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 332 in rest-api/src/main/java/life/qbic/data_download/rest/download/MeasurementFileController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This branch's code block is the same as the block for the branch on line 324. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBcTr561BCnmIPICYEj&open=AaBcTr561BCnmIPICYEj&pullRequest=107

Check warning on line 103 in rest-api/src/main/java/life/qbic/data_download/rest/config/SecurityConfig.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBcTr2M1BCnmIPICYEf&open=AaBcTr2M1BCnmIPICYEf&pullRequest=107

Check warning on line 48 in openbis-connector/src/test/java/life/qbic/data_download/openbis/OpenBisNfsStorageProviderTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBXLenZ-3K_-tFSGbHS&open=AaBXLenZ-3K_-tFSGbHS&pullRequest=107

Check warning on line 65 in storage-provider/src/test/java/life/qbic/data_download/storage/ByteRangeTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBIjfCI3f23caWmxc78&open=AaBIjfCI3f23caWmxc78&pullRequest=107

Check warning on line 45 in rest-api/src/main/java/life/qbic/data_download/rest/config/SecurityConfig.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'org.springframework.security.config.Customizer'. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBcTr2M1BCnmIPICYEg&open=AaBcTr2M1BCnmIPICYEg&pullRequest=107

Check warning on line 7 in storage-provider/src/main/java/life/qbic/data_download/storage/exception/NetworkException.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This class has 6 parents which is greater than 5 authorized. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBIje_G3f23caWmxc72&open=AaBIje_G3f23caWmxc72&pullRequest=107

Check warning on line 8 in rest-api/src/test/java/life/qbic/data_download/rest/download/StorageFileIndexTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'java.util.Optional'. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBXDb5OKDu51zO0-S_E&open=AaBXDb5OKDu51zO0-S_E&pullRequest=107

Check warning on line 9 in openbis-connector/src/test/java/life/qbic/data_download/openbis/OpenBisNfsStorageProviderTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'life.qbic.data_download.storage.exception.StorageProviderException'. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBXLenZ-3K_-tFSGbHU&open=AaBXLenZ-3K_-tFSGbHU&pullRequest=107

Check warning on line 7 in storage-provider/src/main/java/life/qbic/data_download/storage/exception/ProviderUnavailableException.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This class has 6 parents which is greater than 5 authorized. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBIjfAM3f23caWmxc73&open=AaBIjfAM3f23caWmxc73&pullRequest=107

Check warning on line 103 in rest-api/src/main/java/life/qbic/data_download/rest/config/SecurityConfig.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBcTr2M1BCnmIPICYEe&open=AaBcTr2M1BCnmIPICYEe&pullRequest=107

Check warning on line 41 in storage-provider/src/test/java/life/qbic/data_download/storage/ByteRangeTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBIjfCI3f23caWmxc77&open=AaBIjfCI3f23caWmxc77&pullRequest=107

Check warning on line 62 in openbis-connector/src/test/java/life/qbic/data_download/openbis/OpenBisNfsStorageProviderTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertDoesNotThrow() instead of try/catch and fail() in the catch block. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBXLenZ-3K_-tFSGbHT&open=AaBXLenZ-3K_-tFSGbHT&pullRequest=107

Check warning on line 16 in rest-api/src/main/java/life/qbic/data_download/rest/storage/ProviderRegistryConfig.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'life.qbic.data_download.storage.StorageProvider'. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBWzeQkOjtWm0_y7u3X&open=AaBWzeQkOjtWm0_y7u3X&pullRequest=107

Check warning on line 18 in rest-api/src/test/java/life/qbic/data_download/rest/storage/ProviderRegistryConfigTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'org.springframework.boot.context.annotation.UserConfigurations'. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBcTr_R1BCnmIPICYEl&open=AaBcTr_R1BCnmIPICYEl&pullRequest=107

Check warning on line 35 in storage-provider/src/test/java/life/qbic/data_download/storage/ByteRangeTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBIjfCI3f23caWmxc76&open=AaBIjfCI3f23caWmxc76&pullRequest=107

Check warning on line 217 in rest-api/src/main/java/life/qbic/data_download/rest/download/MeasurementFileController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter "measurementId". 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBcTr561BCnmIPICYEh&open=AaBcTr561BCnmIPICYEh&pullRequest=107

Check warning on line 7 in rest-api/src/test/java/life/qbic/data_download/rest/download/MeasurementFileControllerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'org.junit.jupiter.api.Assertions.assertTrue'. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBcTr9c1BCnmIPICYEk&open=AaBcTr9c1BCnmIPICYEk&pullRequest=107

Check warning on line 24 in storage-provider/src/main/java/life/qbic/data_download/storage/ByteRangeParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use concise character class syntax '\\d' instead of '[0-9]'. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBIjfBY3f23caWmxc75&open=AaBIjfBY3f23caWmxc75&pullRequest=107

Check failure on line 246 in rest-api/src/main/java/life/qbic/data_download/rest/download/MeasurementFileController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 29 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBcTr561BCnmIPICYEi&open=AaBcTr561BCnmIPICYEi&pullRequest=107

Check warning on line 41 in openbis-connector/src/test/java/life/qbic/data_download/openbis/OpenBisNfsStorageProviderTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertDoesNotThrow() instead of try/catch and fail() in the catch block. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBXLenZ-3K_-tFSGbHR&open=AaBXLenZ-3K_-tFSGbHR&pullRequest=107

Check warning on line 64 in storage-provider/src/test/java/life/qbic/data_download/storage/ConfigurableProviderRegistryTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBWzeUFOjtWm0_y7u3Z&open=AaBWzeUFOjtWm0_y7u3Z&pullRequest=107

Check warning on line 24 in storage-provider/src/main/java/life/qbic/data_download/storage/ByteRangeParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use concise character class syntax '\\d' instead of '[0-9]'. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBIjfBY3f23caWmxc74&open=AaBIjfBY3f23caWmxc74&pullRequest=107

Check warning on line 63 in storage-provider/src/test/java/life/qbic/data_download/storage/ConfigurableProviderRegistryTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "factory" which hides the field declared at line 17. 

See more on https://sonarcloud.io/project/issues?id=qbicsoftware_data-download-server&issues=AaBWzeUFOjtWm0_y7u3Y&open=AaBWzeUFOjtWm0_y7u3Y&pullRequest=107
View more details on SonarQubeCloud