Skip to content

Missing interval between repeated CM_START_ATTEN_CHAR.IND #193

Description

@sjuliancarrizo

Hello,

Commit 7fb8ac5 updated slac/pev_cm_start_atten_char.c to transmit CM_START_ATTEN_CHAR.IND three times, which aligns with ISO 15118-3 (parameter C_EV_start_atten_char_inds = 3).

However, ISO 15118-3 also specifies that there shall be a time interval TP_EV_batch_msg_interval (20–50 ms) between consecutive CM_START_ATTEN_CHAR.IND messages. In the current implementation, the three sendmessage() calls are executed back-to-back with no delay.

Proposed fix
Insert a sleep after each transmission using the existing session pause value (same one used elsewhere in SLAC).

SLEEP (session->pause);

Using session->pause (commonly defined via SLAC_PAUSE) would keep behavior consistent with the existing timing configuration and can be set to a value within 20–50 ms.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions