docs: explain ONNX runtime and local-only loading options - #708
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughREADME.md adds an “ONNX Runtime and local-only loading” section. The section documents thread and CPU memory-arena settings, model cache prepopulation while online, offline initialization with Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: 🟡 Moderate · up to The new cache-preparation instructions may fail to download models into an empty cache, preventing the documented offline setup from working. Resolve the example or its described behavior before merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I checked the cache-preparation concern against PR commit a05599d with the real
Environment: Windows, Python 3.10.11, this checkout installed as FastEmbed 0.8.0, huggingface-hub 1.30.0, ONNX Runtime 1.23.2, NumPy 2.2.6. I couldn't reproduce the reported download failure, so I've left the examples unchanged and updated the PR's validation notes. |
Documents how to configure ONNX session thread counts and
enable_cpu_mem_arena, then populate a cache online and reuse it withlocal_files_only=True. It also explains the missing-cache error so offline deployments can be prepared correctly.Addresses the runtime-options and local-only-loading parts of #579. Complements #638, which documents general cache configuration.
Validation: Python snippet syntax checks and
git diff --checkpass. A real-model check on Windows/Python 3.10.11 populated a fresh cache, reproduced identical embeddings in a fresh local-only process with Python socket/DNS calls blocked (zero attempts), verified the empty-cache ValueError, and confirmed both ONNX thread counts and the memory-arena setting. See the validation follow-up comment for versions and scope. Full repository tests were not run locally.AI assistance was used to prepare and review this change.
All Submissions: