Skip to content

fix: accept a bare point id as a prefetch query in local mode - #1401

Merged
joein merged 1 commit into
devfrom
fix-prefetch-bare-point-id
Sep 3, 2026
Merged

fix: accept a bare point id as a prefetch query in local mode#1401
joein merged 1 commit into
devfrom
fix-prefetch-bare-point-id

Conversation

@joein

@joein joein commented Sep 3, 2026

Copy link
Copy Markdown
Member

No description provided.

@netlify

netlify Bot commented Sep 3, 2026

Copy link
Copy Markdown

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 372bfb5
🔍 Latest deploy log https://app.netlify.com/projects/poetic-froyo-8baba7/deploys/6a99b034e117f100087d3cba
😎 Deploy Preview https://deploy-preview-1401--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: bb56eb82-86e9-4fbe-8299-3a39223784c8

📥 Commits

Reviewing files that changed from the base of the PR and between 65239c6 and 372bfb5.

📒 Files selected for processing (2)
  • qdrant_client/local/async_qdrant_local.py
  • qdrant_client/local/qdrant_local.py

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The local synchronous and asynchronous clients now convert bare query inputs into NearestQuery objects. Point ID vector lookup uses LocalCollection._vector_by_point_id. Congruence helpers and tests cover direct point ID prefetch, nested point ID prefetch, and lookup collection resolution across local, REST, and gRPC clients.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 372bf

Local synchronous and asynchronous clients now accept bare point IDs for prefetch queries while preserving existing query-model handling. No current merge-blocking risk remains identified.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided, so the change is not explained in the author-provided description. Add a concise description that explains the local-mode bare point ID support and the related prefetch query tests.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: accepting a bare point ID as a prefetch query in local mode.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-prefetch-bare-point-id

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@joein
joein force-pushed the fix-prefetch-bare-point-id branch from 65239c6 to 372bfb5 Compare September 3, 2026 17:36
@joein
joein merged commit 51d048a into dev Sep 3, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant