Skip to content

Core: Ch579m support#26097

Draft
ryanm101 wants to merge 13 commits into
qmk:developfrom
ryanm101:ch579m_support
Draft

Core: Ch579m support#26097
ryanm101 wants to merge 13 commits into
qmk:developfrom
ryanm101:ch579m_support

Conversation

@ryanm101

@ryanm101 ryanm101 commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Adds Support for CH579M based Keyboards:
image

Description

depends on ChibiOS/ChibiOS-Contrib#437

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [] Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions Bot added core keyboard keymap python cli qmk cli command dd Data Driven Changes labels Mar 20, 2026
@zvecr zvecr changed the base branch from master to develop March 20, 2026 14:47
@zvecr zvecr added the no-ci Signals to the CI runners not to build. label Mar 20, 2026
enc1 - a
enc2 - b
c|d|nkeh
f|g|nkeh
i|jm|nkeh
l|jm|nkeh

The Analog keys seem be causing some issues, this could perhaps be due to a chip problem if i broke something while probing.
…ted my board and A1/A2, A3/A15, A13/14 are now failing to work
@ryanm101 ryanm101 marked this pull request as ready for review March 21, 2026 17:25
@ryanm101 ryanm101 changed the title WIP: Ch579m support Feature: Ch579m support Mar 21, 2026
@zvecr zvecr marked this pull request as draft March 21, 2026 20:02
@zvecr zvecr added invalid awaiting_pr Relies on another PR to be merged first labels Mar 21, 2026
@ryanm101 ryanm101 changed the title Feature: Ch579m support Core: Ch579m support Mar 22, 2026
@ryanm101

Copy link
Copy Markdown
Contributor Author

Moved the keyboard portion to #26100 per the contrib guide

@ryanm101 ryanm101 marked this pull request as ready for review March 22, 2026 07:42
@ryanm101

ryanm101 commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

chibios-21.11.x has support now. This is ready for merge

@zvecr

zvecr commented Apr 9, 2026

Copy link
Copy Markdown
Member

Outside of chibios-contrib needing to be updated separately to pull in a later version, I don't think we would consider the port of high enough quality at the moment for us to add support.

I will update this comment when I have a little more time, but this includes:

  • QMK specific variables that have bleed into the chibios-contrib port
  • The usb driver looks particularly bad
    • Required use of NO_USB_STARTUP_CHECK
    • Coupled to expectations on QMKs endpoint use

This PR, as well as the dependent keyboard PR, also has quite a number of issues that would block it from being merged. These include not following the existing conventions and abstractions set up in the code base.

Marking as draft so that it does not accidentally get merged.

@zvecr zvecr marked this pull request as draft April 9, 2026 07:30
@ryanm101

ryanm101 commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

Thanks once you update I'll look. Ignore the keyboard part for now its state is due to my splitting it out from this, I plan to revamp it once this is merged as its the easy part.

Id defo appreciate a suggestion on naming convention for kb as its a generic multi brand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting_pr Relies on another PR to be merged first cli qmk cli command core dd Data Driven Changes invalid keyboard keymap no-ci Signals to the CI runners not to build. python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants