Repository navigation
fix: let the version resolve when only upstream tags are reachable - #8
Merged
Merged
Conversation
#7's tag_regex matched only `quadbio-*`, so setuptools_scm raised `Can't parse version from tag '1.1.61'` on upstream's tags -- which are the nearest ones reachable from main, since our two release tags were orphaned by the old force-pushed integration branch. That broke release.yml on every push to main. Make the prefix optional so upstream's tags parse as a fallback, and only require the +quadbio. segment on release builds: a build off an untagged main is a .devN artifact that is never published and has no local segment to carry. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQnnW5jCKXnefXA89eBDoL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release.ymlis currently red onmain— run 33050739790:#7's
tag_regexmatched onlyquadbio-*. But upstream's tags (1.1.61,1.1.59.post1, …) arereachable from
main, and they are currently the nearest ones — our two release tags wereorphaned by the old force-pushed
integrationbranch. setuptools_scm raises rather than fallingback when the nearest tag doesn't match.
I missed this because I verified the regex in a scratch repo that had only
quadbio-*tags.Two changes:
^(?:quadbio-)?(?P<version>.+)$— so upstream's tags parse as afallback. Verified against the real repo: resolves to
1.1.62.dev32+g3070196bc.check_wheel.pyrequires+quadbio.only on release builds. A build off an untaggedmainis a.devNartifact that is never published and has no local segment to carry;without this, every push to
mainwould fail the check until the firstquadbio-*tag lands.1.1.61+quadbio.31.1.62.dev32+g30701961.1.62.dev1+quadbio.3.gabc1.1.61.post2Once
quadbio-1.1.61+quadbio.3is tagged onmainit becomes the nearest tag and dev buildscarry the marker too.