Skip to content

fix: let the version resolve when only upstream tags are reachable - #8

Merged
Marius1311 merged 1 commit into
mainfrom
fix/version-derivation
Aug 27, 2026
Merged

Marius1311 merged 1 commit into
mainfrom
fix/version-derivation

Conversation

@Marius1311

Copy link
Copy Markdown
Member

release.yml is currently red on main — run 33050739790:

ValueError: Error getting the version from source `vcs`:
Can't parse version from tag '1.1.61' (tag_regex='^quadbio-(?P<version>.+)$', tag_prefix='')

#7's tag_regex matched only quadbio-*. But upstream's tags (1.1.61, 1.1.59.post1, …) are
reachable from main, and they are currently the nearest ones — our two release tags were
orphaned by the old force-pushed integration branch. setuptools_scm raises rather than falling
back when the nearest tag doesn't match.

I missed this because I verified the regex in a scratch repo that had only quadbio-* tags.

Two changes:

  1. Make the prefix optional — ^(?:quadbio-)?(?P<version>.+)$ — so upstream's tags parse as a
    fallback. Verified against the real repo: resolves to 1.1.62.dev32+g3070196bc.
  2. check_wheel.py requires +quadbio. only on release builds. A build off an untagged
    main is a .devN artifact that is never published and has no local segment to carry;
    without this, every push to main would fail the check until the first quadbio-* tag lands.
version verdict
1.1.61+quadbio.3 accept
1.1.62.dev32+g3070196 accept (dev)
1.1.62.dev1+quadbio.3.gabc accept
1.1.61.post2 reject — release without our marker

Once quadbio-1.1.61+quadbio.3 is tagged on main it becomes the nearest tag and dev builds
carry the marker too.

#7's tag_regex matched only `quadbio-*`, so setuptools_scm raised
`Can't parse version from tag '1.1.61'` on upstream's tags -- which are the
nearest ones reachable from main, since our two release tags were orphaned by
the old force-pushed integration branch. That broke release.yml on every push
to main.

Make the prefix optional so upstream's tags parse as a fallback, and only
require the +quadbio. segment on release builds: a build off an untagged main
is a .devN artifact that is never published and has no local segment to carry.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQnnW5jCKXnefXA89eBDoL
@Marius1311
Marius1311 merged commit afbc1f0 into main Aug 27, 2026
2 checks passed
@Marius1311
Marius1311 deleted the fix/version-derivation branch August 27, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant