camx: revision update for Hamoa, Lemans, Talos,Kodiak#2494
Conversation
|
@lumag / @ricardosalveti please help to add PR user "qli-2.0 GA Critical Fix" and "backport wrynose" labels/Milestone |
|
qli-2.0 GA Critical Fix |
Test Results 105 files + 78 634 suites +607 4h 42m 58s ⏱️ + 3h 36m 23s Results for commit a8bbce4. ± Comparison against base commit 7b61b62. This pull request removes 2 and adds 114 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
572e9eb to
2ca6d44
Compare
lumag
left a comment
There was a problem hiding this comment.
As discussed during the meeting today, that's too many new features to be submitted after 2.0 deadline. Please provide separate patch releases (1.0.x.y) fixing only the bugs (e.g. jpeg corruption issue due to format mismatch). This can go in after 2.0 GA.
jpeg corruption issue due to format mismatch Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
- jpeg corruption issue due to format mismatch - Enable Electronic Image Stabilization (EIS) and Lens Distortion Correction (LDC) support for Talos. - Update recipe to include EGL and GLES dependencies, and conditionally add OpenCL support based on DISTRO_FEATURES. Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
bcb2952 to
c117c3f
Compare
| SRC_URI[chicdk.sha256sum] = "9b08fe81bc9177826fe5d9aff185de16bdb216cab20304bfea60a8c8a5c2eb48" | ||
| SRC_URI[camxcommon.sha256sum] = "9e8a7b595242916962bb018f2dffc3136c399f1bf80b0aecd91f4ac97f6293f9" | ||
|
|
||
| DEPENDS += "virtual/egl virtual/libgles2 ${@bb.utils.contains('DISTRO_FEATURES', 'opencl', 'qcom-adreno virtual/libopencl1', '', d)}" |
There was a problem hiding this comment.
Why do you need qcom-adreno as a build-time dependency?
Also, EGL and GL ES2 are optional features which can be disabled on a distro level.
There was a problem hiding this comment.
qcom-adreno is needed here because the Talos EIS/LDC build compiles OpenCL-based code and currently fails without the Qualcomm OpenCL extension headers.
"fatal error: CL/cl_ext_qcom.h: No such file or directory"
EGL and GLES2 features are enabled by default in the base Config1 image; therefore, the required graphics stack is already available in the standard build configuration.
Also we are getting error for all dependent library on meta qcom if we don't include in DEPENDS.
ERROR: camxlib-talos-1.0.27-r0 do_package_qa: QA Issue: /usr/lib/camx/talos/camera/components/libiwarp.so.0.1.0 contained in package camxlib-talos requires libOpenCL.so.1(OPENCL_1.1)(64bit), but no providers found in RDEPENDS:camxlib-talos? [file-rdeps]
ERROR: camxlib-talos-1.0.27-r0 do_package_qa: QA Issue: /usr/lib/camx/talos/camera/components/libiwarp.so.0.1.0 contained in package camxlib-talos requires libEGL.so.1()(64bit), but no providers found in RDEPENDS:camxlib-talos? [file-rdeps]
ERROR: camxlib-talos-1.0.27-r0 do_package_qa: QA Issue: /usr/lib/camx/talos/camera/components/libiwarp.so.0.1.0 contained in package camxlib-talos requires libGLESv2.so.2()(64bit), but no providers found in RDEPENDS:camxlib-talos? [file-rdeps]
There was a problem hiding this comment.
What exactly are you building here? Move build dependencies to the place where the build happens.
Regarding the link errors. Guard your additions by the DISTRO_FEATURES check. You can check that it works by performing a nodistro build and removing the opengl and opencl features from the nodistro. The build should succeed without requiring non-existing libs.
There was a problem hiding this comment.
are you looking to add condition check for virtual/egl virtual/libgles2 package just like virtual/libopencl1
DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'virtual/egl virtual/libgles2', '', d)}
${@bb.utils.contains('DISTRO_FEATURES', 'opencl', 'virtual/libopencl1', '', d)}"
There was a problem hiding this comment.
Yes. Also please, check it without those distro features, as I wrote before.
|
|
||
|
|
||
|
|
||
| DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'opencl', 'qcom-adreno virtual/libopencl1', '', d)}" |
There was a problem hiding this comment.
similar we have Opencl dependency for SWMCTF feature on lemans.
There was a problem hiding this comment.
It is software solution for Temporal Noise Reduction.
There was a problem hiding this comment.
Ok. Anyway, make sure that the package actually builds if opencl and opengl are disabled.
- jpeg corruption issue due to format mismatch
- Add CAM0B support to enable OV9282 combo mode on Lemans.
- Enable Deep Learning based Face Detection on Lemans.
- Created a separate package for SKEL files and added INSANE_SKIP for
"arch libdir" specifically for that package.
- Disable auto-renaming for ${PN}-skel to preserve consistent package
naming.
Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
- Enable Deep Learning based Face Detection in Kodiak.
- Add support for 3-frame SHDR (YUV SHDR) pipeline on Kodiak.
- Created a separate package for SKEL files and added INSANE_SKIP for
"arch libdir" specifically for that package.
- Disable auto-renaming for ${PN}-skel to preserve consistent package
naming.
- Link additional libraries and enable whole archive static linking for
few libs required for CamX compilation.
Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
- Source/header mismatch causes CamX compilation failure. - Update the headers tar to align with the sources. Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
c117c3f to
a8bbce4
Compare
|
@lumag / @ricardosalveti , |
|
@p-badge requested to pick this up, as some of the features planned for GA depend on it. |
|
Successfully created backport PR for |
My answer would have been, no. You have submitted and now we have merged a PR which is likely broken in some configurations. |
|
With the With |
@lumag , Guard logic for opencl and opengl dependent lib is implemented on PR 2560 |
camxlib-kodiak: Update to the 1.0.24 revision
camxlib-lemans: update to the 1.0.27 revision
camxlib-talos: Update to the 1.0.27 revision
camxlib-hamoa: update to the 1.0.27 revision
camxcommon-headers: Update to the 1.0.11 revision
qli-2.0 GA Critical Fix