ci: performance: enable NM wait-online override#2553
Open
DaizhuangBai wants to merge 1 commit into
Open
Conversation
Enable the NetworkManager wait-online override only for performance
builds by setting:
NETWORKMANAGER_WAIT_ONLINE_WAIT_FOR_STARTUP = "0"
This keeps the generic distro behavior unchanged while applying the
boot-time optimization in performance profile.
Signed-off-by: Daizhuang Bai <daizhuang.bai@oss.qualcomm.com>
DaizhuangBai
requested review from
lumag,
mwasilew,
ndechesne,
quaresmajose and
ricardosalveti
as code owners
Contributor
|
Again, this is the wrong fix, we should fix the services depending on network-online. https://networkmanager.dev/docs/api/latest/NetworkManager-wait-online.service.html Optimally, all services on the host react dynamically to network changes and systemd services do not need to be configured to start after reaching the network-online target. In this case, NetworkManager-wait-online.service has no effect and does not delay the boot time. On the other hand, if you encounter a long boot time due to the delay of NetworkManager-wait-online, investigate the services that require network access and fix them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the NetworkManager wait-online override only for performance builds by setting:
This keeps the generic distro behavior unchanged while applying the boot-time optimization in performance profile.