Include modem firmware placeholder in packagegroup-qcm6490-idp#2561
Open
vkraleti wants to merge 1 commit into
Open
Include modem firmware placeholder in packagegroup-qcm6490-idp#2561vkraleti wants to merge 1 commit into
vkraleti wants to merge 1 commit into
Conversation
linux-firmware.git does not provide modem firmware for QCM6490. However QCM6490-IDP has modem support and for this to work appropriate firmware needs to be included in image. Define an empty placeholder package and by default include it in the packagegroup-qcm6490-idp so that users can override it with vendor provided firmware. Signed-off-by: Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com>
vkraleti
requested review from
anujm1,
koenkooi,
lumag,
ndechesne and
ricardosalveti
as code owners
lumag
reviewed
Jun 20, 2026
| ALTERNATIVE_LINK_NAME[ar6004-hw13-bdata] = "${nonarch_base_libdir}/firmware/ath6k/AR6004/hw1.3/bdata.bin${@fw_compr_file_suffix(d)}" | ||
|
|
||
| # A placeholder package for vendors to override | ||
| PACKAGES:append:qcom = " ${PN}-qcom-qcm6490-modem" |
Contributor
There was a problem hiding this comment.
There should be no need in this assignment.
Contributor
Author
There was a problem hiding this comment.
Without this facing an error.
Missing or unbuildable dependency chain was: ['packagegroup-core-boot', 'packagegroup-qcm6490-idp-firmware', 'linux-firmware-qcom-qcm6490-modem']
ERROR: Required build target 'qcom-multimedia-image' has no buildable providers.
Missing or unbuildable dependency chain was: ['qcom-multimedia-image', 'packagegroup-core-boot', 'packagegroup-qcm6490-idp-firmware', 'linux-firmware-qcom-qcm6490-modem']
Contributor
There was a problem hiding this comment.
Hmm. Can we instead implement a recipes repackaging NON-HLOS.bin (see how it's done for HDKs)? At least then users can provide NHLOS.bin and get the result (TC is providing modem firmware for RB3 Gen2 in the NHLOS.bin as a part of the SDK).
Contributor
There was a problem hiding this comment.
That would require two recipes, one for RB3 Gen2, one for IDP, installing firmware to different locations (because they are not the same).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linux-firmware.git does not provide modem firmware for QCM6490. However QCM6490-IDP has modem support and for this to work appropriate firmware needs to be included in image. Define an empty placeholder package and by default include it in the packagegroup-qcm6490-idp so that users can override it with vendor provided firmware.