platforms/iq-x7181-evk: update additional_chipid in contents.xml.in#127
Open
GuanquanTian wants to merge 1 commit into
Open
platforms/iq-x7181-evk: update additional_chipid in contents.xml.in#127GuanquanTian wants to merge 1 commit into
GuanquanTian wants to merge 1 commit into
Conversation
lumag
reviewed
Jun 22, 2026
lumag
left a comment
Contributor
There was a problem hiding this comment.
Signed-off-by: guanquan guanquan@qti.qualcomm.com
Is it your legal name? Or just an ignorance of the Git configuration?
| <chipid flavor="default" storage_type="spinor" flash_phase="1">HAMOA</chipid> | ||
| <chipid flavor="ub_qcom_server" storage_type="UFS" flash_phase="2">HAMOA</chipid> | ||
| <additional_chipid>HAMOA,Hamoa_IOT,Purwa_IoT</additional_chipid> | ||
| <additional_chipid>sc8380x,SC8380XP,HAMOA,QX8141_OLYMPIC,SC8340X,SC8340XP,Purwa,X1P42100,X1P44100,X1P46100,Hamoa_IOT,Purwa_IoT,X1E80100,X1P4x100,IQX7181,IQX5121</additional_chipid> |
Contributor
There was a problem hiding this comment.
Why do we need so many of them here?
Contributor
Author
There was a problem hiding this comment.
I reused the hamoa ubuntu build contents.xml.in file in this section, which can be applied normally by the APT team.
https://github.com/qualcomm-linux/qcom-distro-images/blob/main/platform/hamoa-evk/contents.xml.in
Contributor
There was a problem hiding this comment.
You didn't actually answer the question. You said what you did, you didn't explain why we need all of them.
| 076a27c79e5ace2a3d47f9dd2e83e4ff6ea8872b3c2218f66c92b89b55f36560 platforms/iq-x7181-evk/nvme/zeros_1sector.bin | ||
| f57511198cd295e9187ab5e6153bd837c4ee91d0217ea593d6b767ca37fa74c2 platforms/iq-x7181-evk/nvme/zeros_33sectors.bin | ||
| 307bb16392f3b1f28f9023da7f609d76ac9ccc7ea4744cb7663d491faae5a851 platforms/iq-x7181-evk/spinor/contents.xml | ||
| 92ff39930e52214ae344690c654e7c3288084acaf795e479171f4c1167cbb256 platforms/iq-x7181-evk/spinor/contents.xml |
Contributor
Author
There was a problem hiding this comment.
okay, will be merged into one commit submission.
Expand additional_chipid to include SC8380X/SC8380XP, SC8340X/SC8340XP, X1E80100, X1P4x100 series, IQX7181, IQX5121 and QX8141_OLYMPIC chip IDs. This fixes an issue where the APT team was unable to add Hamoa & Purwa LE pools in Axiom when triggering jobs. Signed-off-by: Guanquan Tian <guanquan@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand additional_chipid to include SC8380X/SC8380XP, SC8340X/SC8340XP, X1E80100, X1P4x100 series, IQX7181, IQX5121 and QX8141_OLYMPIC chip IDs.
This fixes an issue where the APT team was unable to add Hamoa & Purwa LE pools in Axiom when triggering jobs.