postgres: alias insertion deadlock#1891
Open
hdonnay wants to merge 3 commits into
Open
Conversation
hdonnay
force-pushed
the
bug/sql-concurrent-alias
branch
2 times, most recently
from
May 27, 2026 19:49
b8d0c0b to
da65def
Compare
hdonnay
force-pushed
the
bug/sql-concurrent-alias
branch
from
May 28, 2026 18:46
da65def to
a43e074
Compare
hdonnay
force-pushed
the
bug/sql-concurrent-alias
branch
2 times, most recently
from
May 29, 2026 15:38
136e223 to
5928a1b
Compare
9 tasks
Contributor
|
This appears to stop the deadlocks but causes the time to insert to increase considerably. Since we are inserting the aliases and namespaces outside of the transaction (so IIUC deadlocking is not an issue), would it be possible to collect all the aliases to be inserted using the dedupe maps that already exist and fire two bulk statements for the alias and the namespace? |
Member
Author
|
I'll take a look and try structuring it that way. |
hdonnay
force-pushed
the
bug/sql-concurrent-alias
branch
2 times, most recently
from
July 15, 2026 19:33
96286f2 to
25bd69e
Compare
Member
Author
hdonnay
marked this pull request as ready for review
July 15, 2026 19:40
hdonnay
force-pushed
the
bug/sql-concurrent-alias
branch
2 times, most recently
from
July 15, 2026 20:09
020f257 to
428280d
Compare
jvdm
reviewed
Jul 16, 2026
jvdm
left a comment
jvdm
left a comment
Contributor
There was a problem hiding this comment.
Can we pull TestConcurrentUpdateVulnerabilities from #1934 which seems to test the deadlock?
Also, looks like this does not have the self alias fields on the test vulns in TestGetLatestVulnerabilities that #1934 added. Without the self fields, bulkLinkSelf is never exercised: no self set, vsHashKinds stays empty and the bulkLinkSelf statement never runs.
Member
Author
|
I removed that test because it didn't work; I could never get it to trip. The other changes to the tests were unintentional, I'll pull those back. |
This fixes a transaction conflict where concurrent updaters could attempt to insert the same alias namespaces and cause the entire update to abort. Signed-off-by: Hank Donnay <hdonnay@redhat.com> Change-Id: I4f7f613f17e47c7cbcff82fbbb7674a06a6a6964
Replace the per-vulnerability insertVulnerabilityAliases and insertSelfAlias batch queries -- each of which did a hash-lookup subquery against the vuln table -- with two single bulk INSERT statements that use unnest() + JOIN to link all vulnerabilities to their aliases and self-references in one pass. The flattened (hash_kind, hash, alias_space, alias_name) arrays accumulated during the vuln iteration are comparable in size to the arrays already built by the insertAliases pre-pass, so memory usage does not grow significantly relative to what was already held. For VEX with a 2-year lookback (~1.1M vulns), this reduces the alias-linking phase from timing out at 30 minutes to ~43 seconds. Signed-off-by: crozzy <joseph.crosland@gmail.com> Change-Id: Icc408d5593c3eca5832ca32a72fe65f86a6a6964
This fixes a bug where `insertAliases` consumes the single-pass `vulnIter` (backed by `jsonblob.RecordIter`) before the main vulnerability insertion loop runs, resulting in zero vuln rows being inserted. The fix removes the separate `insertAliases` pre-pass and instead collects alias namespaces and aliases during the main `vulnIter` loop, then bulk-inserts them via a separate connection (outside the transaction) after the loop -- preserving the deadlock-avoidance property. Also adds a test using a `sync.Once`-guarded single-pass iterator that reproduces the bug. Signed-off-by: Hank Donnay <hdonnay@redhat.com> Change-Id: I764435cfde1f62b7492dc056824e8b606a6a6964
hdonnay
force-pushed
the
bug/sql-concurrent-alias
branch
from
July 17, 2026 00:43
428280d to
40ee906
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a transaction conflict where concurrent updaters could attempt to insert the same alias namespaces and cause the entire update to abort.