Skip to content

Remove readiness probe in favor of startup probe #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nadav-govari wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove readiness probe in favor of startup probe #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/quickwit/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: quickwit
description: Sub-second search & analytics engine on cloud storage.
type: application
version: 0.8.13
version: 0.8.14
appVersion: v0.8.2
keywords:
- quickwit
Expand Down
4 changes: 3 additions & 1 deletion charts/quickwit/templates/_metastore-deployment.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,10 @@ spec:
{{- toYaml $values.startupProbe | nindent 12 }}
livenessProbe:
{{- toYaml $values.livenessProbe | nindent 12 }}
{{- with $values.readinessProbe }}
readinessProbe:
{{- toYaml $values.readinessProbe | nindent 12 }}
{{- toYaml . | nindent 12 }}
{{- end }}
volumeMounts:
- name: config
mountPath: /quickwit/node.yaml
Expand Down
4 changes: 3 additions & 1 deletion charts/quickwit/templates/compactor-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,10 @@ spec:
{{- toYaml .Values.compactor.startupProbe | nindent 12 }}
livenessProbe:
{{- toYaml .Values.compactor.livenessProbe | nindent 12 }}
{{- with .Values.compactor.readinessProbe }}
readinessProbe:
{{- toYaml .Values.compactor.readinessProbe | nindent 12 }}
{{- toYaml . | nindent 12 }}
{{- end }}
volumeMounts:
- name: config
mountPath: /quickwit/node.yaml
Expand Down
4 changes: 3 additions & 1 deletion charts/quickwit/templates/control-plane-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,10 @@ spec:
{{- toYaml .Values.control_plane.startupProbe | nindent 12 }}
livenessProbe:
{{- toYaml .Values.control_plane.livenessProbe | nindent 12 }}
{{- with .Values.control_plane.readinessProbe }}
readinessProbe:
{{- toYaml .Values.control_plane.readinessProbe | nindent 12 }}
{{- toYaml . | nindent 12 }}
{{- end }}
volumeMounts:
- name: config
mountPath: /quickwit/node.yaml
Expand Down
4 changes: 3 additions & 1 deletion charts/quickwit/templates/indexer-statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,10 @@ spec:
{{- toYaml .Values.indexer.startupProbe | nindent 12 }}
livenessProbe:
{{- toYaml .Values.indexer.livenessProbe | nindent 12 }}
{{- with .Values.indexer.readinessProbe }}
readinessProbe:
{{- toYaml .Values.indexer.readinessProbe | nindent 12 }}
{{- toYaml . | nindent 12 }}
{{- end }}
volumeMounts:
- name: config
mountPath: /quickwit/node.yaml
Expand Down
4 changes: 3 additions & 1 deletion charts/quickwit/templates/janitor-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,10 @@ spec:
{{- toYaml .Values.janitor.startupProbe | nindent 12 }}
livenessProbe:
{{- toYaml .Values.janitor.livenessProbe | nindent 12 }}
{{- with .Values.janitor.readinessProbe }}
readinessProbe:
{{- toYaml .Values.janitor.readinessProbe | nindent 12 }}
{{- toYaml . | nindent 12 }}
{{- end }}
volumeMounts:
- name: config
mountPath: /quickwit/node.yaml
Expand Down
4 changes: 3 additions & 1 deletion charts/quickwit/templates/searcher-statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,10 @@ spec:
{{- toYaml .Values.searcher.startupProbe | nindent 12 }}
livenessProbe:
{{- toYaml .Values.searcher.livenessProbe | nindent 12 }}
{{- with .Values.searcher.readinessProbe }}
readinessProbe:
{{- toYaml .Values.searcher.readinessProbe | nindent 12 }}
{{- toYaml . | nindent 12 }}
{{- end }}
volumeMounts:
- name: config
mountPath: /quickwit/node.yaml
Expand Down
56 changes: 14 additions & 42 deletions charts/quickwit/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ searcher:

startupProbe:
httpGet:
path: /health/livez
path: /health/readyz
port: rest
failureThreshold: 12
periodSeconds: 5
Comment on lines +150 to 153

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Raise the startup probe budget for readyz checks

When /health/readyz takes longer than 60 seconds to return success (for example during a slow metastore/object-store dependency recovery or a cold cluster restart), this new startupProbe kills the container after 12 failures at 5s intervals; the old readinessProbe would simply keep the pod out of endpoints until the dependency recovered. Since the same readyz startupProbe defaults are repeated for the other Quickwit components, a transient >60s readiness delay can turn upgrades into CrashLoopBackOff instead of delayed readiness; please give the startup probe a much larger failureThreshold/period or keep readiness semantics separate.

Useful? React with 👍 / 👎.

Expand All @@ -156,11 +156,7 @@ searcher:
httpGet:
path: /health/livez
port: rest

readinessProbe:
httpGet:
path: /health/readyz
port: rest
timeoutSeconds: 5

# StatefulSet allows you to relax its ordering guarantees
# - OrderedReady
Expand Down Expand Up @@ -257,7 +253,7 @@ indexer:

startupProbe:
httpGet:
path: /health/livez
path: /health/readyz
port: rest
failureThreshold: 12
periodSeconds: 5
Expand All @@ -266,11 +262,7 @@ indexer:
httpGet:
path: /health/livez
port: rest

readinessProbe:
httpGet:
path: /health/readyz
port: rest
timeoutSeconds: 5

# StatefulSet allows you to relax its ordering guarantees
# - OrderedReady
Expand Down Expand Up @@ -370,7 +362,7 @@ metastore:

startupProbe:
httpGet:
path: /health/livez
path: /health/readyz
port: rest
failureThreshold: 12
periodSeconds: 5
Expand All @@ -379,11 +371,7 @@ metastore:
httpGet:
path: /health/livez
port: rest

readinessProbe:
httpGet:
path: /health/readyz
port: rest
timeoutSeconds: 5

# Override args for starting container
args: []
Expand Down Expand Up @@ -453,7 +441,7 @@ metastore_ro:

startupProbe:
httpGet:
path: /health/livez
path: /health/readyz
port: rest
failureThreshold: 12
periodSeconds: 5
Expand All @@ -462,11 +450,7 @@ metastore_ro:
httpGet:
path: /health/livez
port: rest

readinessProbe:
httpGet:
path: /health/readyz
port: rest
timeoutSeconds: 5

# Override args for starting the container.
args: []
Expand Down Expand Up @@ -529,7 +513,7 @@ control_plane:

startupProbe:
httpGet:
path: /health/livez
path: /health/readyz
port: rest
failureThreshold: 12
periodSeconds: 5
Expand All @@ -538,11 +522,7 @@ control_plane:
httpGet:
path: /health/livez
port: rest

readinessProbe:
httpGet:
path: /health/readyz
port: rest
timeoutSeconds: 5

# Override args for starting container
args: []
Expand Down Expand Up @@ -601,7 +581,7 @@ janitor:

startupProbe:
httpGet:
path: /health/livez
path: /health/readyz
port: rest
failureThreshold: 12
periodSeconds: 5
Expand All @@ -610,11 +590,7 @@ janitor:
httpGet:
path: /health/livez
port: rest

readinessProbe:
httpGet:
path: /health/readyz
port: rest
timeoutSeconds: 5

# Override args for starting container
args: []
Expand Down Expand Up @@ -714,7 +690,7 @@ compactor:

startupProbe:
httpGet:
path: /health/livez
path: /health/readyz
port: rest
failureThreshold: 12
periodSeconds: 5
Expand All @@ -723,11 +699,7 @@ compactor:
httpGet:
path: /health/livez
port: rest

readinessProbe:
httpGet:
path: /health/readyz
port: rest
timeoutSeconds: 5

# Override args for starting container
args: []
Expand Down
Loading