Preserve Heads-up Display Layout By Truncating Name and Message Text - #65
Open
tres wants to merge 7 commits into
Open
Preserve Heads-up Display Layout By Truncating Name and Message Text#65tres wants to merge 7 commits into
tres wants to merge 7 commits into
Conversation
added 7 commits
April 3, 2012 12:23
This update ensures that the heads-up display layout is preserved when jobs that have a large amount of associated data are on the queue. It still presents the full name and message text associated with any job in a div visible on hover.
This update adds a little bit of protection to the status display page -- ensuring that if the status.name var isn't set or the status.message var isn't set that we don't try to access their members. It also ensures that the correct var names are used in each place when attempting to find the length of the string.
This update adds a little bit of protection to the status display page -- ensuring that if the status.name var isn't set or the status.message var isn't set that we don't try to access their members. It also ensures that the correct var names are used in each place when attempting to find the length of the string.
Conflicts: lib/resque/server/views/status_styles.erb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update ensures that the heads-up display layout is preserved when
jobs that have a large amount of associated data are on the queue.
It still presents the full name and message text associated with any
job in a div visible on hover.