Adds per_page variable to statuses erb template since Resque 1.23.1+ depends on it. - #90
Open
jonhyman wants to merge 1 commit into
Open
Adds per_page variable to statuses erb template since Resque 1.23.1+ depends on it.#90jonhyman wants to merge 1 commit into
jonhyman wants to merge 1 commit into
Conversation
Author
|
Hey @quirkey, just seeing if you've had a chance to look at this. It's only a few character diff. I updated resque to not require per_page so 1-x-stable HEAD doesn't need it anymore to work, but I still think it's good for the plugins to properly conform to the interface and also it'll fix anyone on 1.23.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The statuses tab is broken in Resque 1.23.1 and higher because the next_more template added a variable,
per_page. This pull request simply passes this value to the erb.