Support for autogenerated ID for formbuilder - #150
Open
cardil wants to merge 7 commits into
Open
Conversation
Author
|
I've pulled latest changes from sammy v0.7.4 and added my fixes to form.js |
…tion.hash` instead of `location` witch previouslly couses a redirect to debug hosted.html file; corrected tests for form builder
Author
|
Hello that have been a while. 3 years almost. Would you merge it? Is it still being developed? |
Contributor
|
@quirkey ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello I've added support for automated generation of form element IDs (they are required to work properly with label element). For example:
This integer from example: 31005 is generated from class-name field and it is there to be sure not to overlap with some other element ID on the webpage (ID should be unique)
You may also notice that I've changed apostrophe with quotation for HTML elements witch is more proper. It was:
and it is now:
I've also modified unit tests to refer those changes