FadeIn/FadeOut - #74
Open
lyuba wants to merge 1 commit into
Open
Conversation
Author
|
Well, just realized that I will not work in a right way with the callback either and here is the case: Somewhere in the root we have: Events are not always binded correctly since then doesn't wait untill swap finishes it's fadeIns/fadeOuts. Even worth situation happen with the renders happening in callbacks. For example, this.partial("layout_view.ejs") What happens here is that content view is not rendered since layout_view was rendered with an asynchronous function. Is there any way to fix then to watch such cases? FadeIn/FadeOut is something really-really wanted :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested code from here is not working as expected:
https://github.com/quirkey/sammy/blob/master/lib/sammy.js#L1107
Added callback to fix.