Skip to content

FadeIn/FadeOut - #74

Open
lyuba wants to merge 1 commit into
quirkey:masterfrom
lyuba:master
Open

FadeIn/FadeOut#74
lyuba wants to merge 1 commit into
quirkey:masterfrom
lyuba:master

Conversation

@lyuba

@lyuba lyuba commented Jan 28, 2011

Copy link
Copy Markdown

Suggested code from here is not working as expected:
https://github.com/quirkey/sammy/blob/master/lib/sammy.js#L1107

Added callback to fix.

@lyuba

lyuba commented Jan 28, 2011

Copy link
Copy Markdown
Author

Well, just realized that I will not work in a right way with the callback either and here is the case:

Somewhere in the root we have:
this.partial(...)
.then(function() {
//bind events
});

Events are not always binded correctly since then doesn't wait untill swap finishes it's fadeIns/fadeOuts.

Even worth situation happen with the renders happening in callbacks. For example,

this.partial("layout_view.ejs")
.render("content_view.ejs")
.appendTo($("#content"));

What happens here is that content view is not rendered since layout_view was rendered with an asynchronous function.

Is there any way to fix then to watch such cases? FadeIn/FadeOut is something really-really wanted :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant