Support array response headers in CGI - #41
Open
OskarEichler wants to merge 2 commits into
Open
Conversation
Member
|
It may be good to include a test that would otherwise fail. |
Author
|
Added a CGI regression covering an array-valued set-cookie header while retaining the existing newline-splitting behavior for String values. The focused test and full local suite pass: 75 runs, 179 assertions, 0 failures. I also checked the failing external CI job: the rackup tests pass there; it fails later because current Falcon now requires Ruby 3.3 while that external job runs Ruby 3.2, so it is unrelated to this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rack 3 permits response header values to be either a String or an Array of Strings. The CGI handler calls
splitdirectly on every value, so it raisesNoMethodErrorfor a conforming array value such as multipleset-cookieheaders.Wrap each value with
Array(...), emit every item separately, and retain the existing newline splitting for legacy String values.Verification:
No breaking API change.