fix(security): 2 improvements across 2 files#1466
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Prototype Pollution via Object Mutation in I18nText Component - Security: Unsafe URL Construction with User-Controlled Data in GlobalAlerts Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Prototype Pollution via Object Mutation in I18nText Component - Security: Unsafe URL Construction with User-Controlled Data in GlobalAlerts Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
Medium| File:src/components/svgs/nodes/i18n-text.tsx:L10The I18nText component directly mutates the
attrsprop object withattrs.content = translateName(attrs.contents). This mutates the original object reference, which can cause unexpected side effects, stale data, or prototype pollution if the object has a modified prototype chain. React props should be treated as immutable.Solution
Create a new object instead of mutating:
const textAttrs = { ...attrs, content: translateName(attrs.contents) };and passtextAttrsto the Text component.Changes
src/components/svgs/nodes/i18n-text.tsx(modified)src/components/page-header/global-alerts.tsx(modified)