Preserve existing source maps when adding line counts - #854
Closed
OskarEichler wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The default source-map preprocessor copies an existing map before adding line-count metadata, preserving caller-owned and frozen maps.
Only the top-level existing map is copied. This preprocessor only writes x_sprockets_linecount; nested arrays/maps are not edited or deeply copied. Nil/empty map construction, line counts, existing metadata and generated output remain unchanged. Verified frozen/mutable maps, index maps, existing line counts, empty content, newline/tail/CRLF/Unicode input.
Reproduction
With
require "sprockets"; require "tmpdir":Verification
bundle exec rake testandbundle exec rake test_isolatedeach pass 913 tests /4,109 assertions /zero failures/errors /four skips on Ruby 3.2.11 and 4.0.6.git diff --checkpasses.Compatibility and limitations
Breaking changes: no intended change to valid supported behavior. Incorrect cache reuse/input mutation/resource retention above changes. No new dependency or version upgrade.
Based on installed release/current upstream main
49d9f20c00ac7d9a7ee57db058961edcccd86699. This is upstream-only; no application fork pin or deployment. Older Ruby/Linux/JRuby verification is left to upstream CI, not claimed locally. Existing tests were not edited or added under the requesting repository's no-test-edit policy; focused reproductions ran externally. Prepared with AI assistance. This is not an exhaustive Sprockets review.