Update file cache size accounting when replacing an entry - #856
Closed
OskarEichler wants to merge 1 commit into
Closed
Update file cache size accounting when replacing an entry#856OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replacing an existing file cache entry adjusts size accounting by the change in stored bytes, so growth can trigger eviction and shrinkage releases capacity.
Reproduction and evidence
A 128-byte FileStore initialized with a small value reports 15 bytes. Replacing the same key with a 200-character string writes 211 bytes but leaves the reported size at 15, so eviction never runs. Record the previous file size and account for the new-minus-old byte delta after writing.
The external checks cover growth, shrinkage, unlimited/limited stores, compressed values, replacing a preexisting entry with a new store instance, retaining unrelated entries after shrinking and serialization failures. Existing cross-process/concurrent-writer accounting remains approximate; this does not claim to make FileStore globally synchronized. Complements #837 (clear accounting), which addresses a different path.
Ruby examples use
require "sprockets"; require "tmpdir".Verification
Compatibility and limitations
Breaking changes: none intended. Overgrown replacement entries can now trigger the existing eviction policy, and shrinking entries no longer consume their old capacity. No new dependencies or version upgrades. Based on installed release/current main
49d9f20c00ac7d9a7ee57db058961edcccd86699.Upstream-only contribution: no application fork pin, deployment or current-master boot claim. No checked-in tests were added or modified under the requesting repository's no-test-edit policy; focused evidence ran externally. Older Ruby/Linux/JRuby verification is left to upstream CI, not claimed locally. Prepared with AI assistance. This is a focused change, not an exhaustive review.