Handle conditional request ETag lists - #859
Closed
OskarEichler wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle comma-separated conditional-request ETags,
*, and RFC weak comparison forIf-None-Matchwhile retaining strong comparison forIf-Match.The current trailing-token extraction ignores earlier list members and wildcards, and treats weak validators as ordinary strong values.
Reproduction
For an asset with ETag
abc,If-None-Match: "other", W/"abc"now returns 304 andIf-Match: "other", "abc"succeeds.If-Match: W/"abc"remains a strong-comparison miss.Verification
Compatibility
Single current validators retain their behavior. No dependency/version change. Existing tests were not edited under the consumer repository’s no-test-edit policy; focused evidence ran externally. Prepared with AI assistance.