Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Still open upstream, so the fix could change. Every row has a patch in `packages

| Package | Version | Fix | PR |
| :--------------------------------------- | :------- | :--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :----------------------------------------------------------------------------------- |
| [`react-native`](packages/react-native/) | n/a | Declare `RCTBundleURLProviderAllowPackagerServerAccess` unconditionally so the dev-only API stops vanishing in Release builds and breaking out-of-tree callers. | [react/react-native#57517](https://github.com/react/react-native/pull/57517) |
| [`expo`](packages/expo/) | n/a | Exit 1 when docs API data generation fails for any package and run the `expotools` test suite in CI, so dead mapping entries stop shipping silently. | [expo/expo#47691](https://github.com/expo/expo/pull/47691) |
| [`expo-updates`](packages/expo-updates/) | `57.0.6` | Fix the Xcode 14+ warning about `EXUpdates.podspec`'s updates-resources script phase on every clean build. | [expo/expo#47622](https://github.com/expo/expo/pull/47622) |
| [`hermes`](packages/hermes/) | n/a | Cherry-pick `1e94fbe0eb` onto `250829098.0.0-stable`. A class declared in a `finally` block miscompiles ([facebook/hermes#1761](https://github.com/facebook/hermes/issues/1761)). | [facebook/hermes#2046](https://github.com/facebook/hermes/pull/2046) |
Expand Down
44 changes: 44 additions & 0 deletions packages/react-native/react-native-pr57517.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
diff --git a/packages/react-native/React/Base/RCTBundleURLProvider.h b/packages/react-native/React/Base/RCTBundleURLProvider.h
index 2d7dc5065374..3b33f9d215f2 100644
--- a/packages/react-native/React/Base/RCTBundleURLProvider.h
+++ b/packages/react-native/React/Base/RCTBundleURLProvider.h
@@ -14,15 +14,15 @@
RCT_EXTERN NSString *_Nonnull const RCTBundleURLProviderUpdatedNotification;
RCT_EXTERN const NSUInteger kRCTBundleURLProviderDefaultPort;

-#if RCT_DEV_MENU | RCT_PACKAGER_LOADING_FUNCTIONALITY
/**
* Allow/disallow accessing the packager server for various runtime scenario.
* For instance, if a test run should never access the packager, disable it
* by calling this function before initializing React Native (RCTBridge etc).
- * By default the access is enabled.
+ * By default the access is enabled. When packager support is compiled out
+ * (neither RCT_DEV_MENU nor RCT_PACKAGER_LOADING_FUNCTIONALITY is set),
+ * calling this function is a no-op.
*/
RCT_EXTERN void RCTBundleURLProviderAllowPackagerServerAccess(BOOL allowed);
-#endif

NS_ASSUME_NONNULL_BEGIN

diff --git a/packages/react-native/React/Base/RCTBundleURLProvider.mm b/packages/react-native/React/Base/RCTBundleURLProvider.mm
index 808925dd08c5..906012b06b26 100644
--- a/packages/react-native/React/Base/RCTBundleURLProvider.mm
+++ b/packages/react-native/React/Base/RCTBundleURLProvider.mm
@@ -19,13 +19,14 @@

const NSUInteger kRCTBundleURLProviderDefaultPort = RCT_METRO_PORT;

-#if RCT_DEV_MENU | RCT_PACKAGER_LOADING_FUNCTIONALITY
+// Declared unconditionally so out-of-tree callers link in every configuration,
+// same shape as RCTDevLoadingViewSetEnabled. Reads stay gated below, so this is
+// a no-op when packager support is compiled out.
static BOOL kRCTAllowPackagerAccess = YES;
void RCTBundleURLProviderAllowPackagerServerAccess(BOOL allowed)
{
kRCTAllowPackagerAccess = allowed;
}
-#endif
static NSString *const kRCTPackagerSchemeKey = @"RCT_packager_scheme";
static NSString *const kRCTJsLocationKey = @"RCT_jsLocation";
static NSString *const kRCTEnableDevKey = @"RCT_enableDev";