Repository navigation
Fix nested filter arrays when a column receives 3+ values - #208
Merged
rjschmitt merged 1 commit intoOct 1, 2026
Merged
Conversation
Contributor
Author
|
Hi, is there something missing in this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
parseFilterschecksArray.isArray(result[key])instead ofArray.isArray(result.filter[key]).The check is always true, so from the third value on, the existing array gets wrapped instead of appended to:
{ 'q@ilike': 'a b c' }→{ q: [['ilike.*a*', 'ilike.*b*'], 'ilike.*c*'] }@or, this yields an invalid logic tree:or=(q.ilike.*a*,ilike.*b*,q.ilike.*c*),which PostgREST rejects with
failed to parse logic tree.It affects any search with 3+ words, and any column with 3+ operators (e.g.
age@gt,age@lt,age@neq).Fix
Check
result.filter[key]. Added tests for 3-wordlike, 3-wordilikeinside@or, and 3 operators on one column.