Upgrade Go to 1.25 - #473
Open
sunnyagg wants to merge 3 commits into
Open
Conversation
- Bump go directive in go.mod from 1.19 to 1.25 - go mod tidy blocked by pre-existing codegen breakage (missing generated mocks/proto/statik packages that also fail on clean checkout) - Update golang base images to c.rzp.io/razorpay/rzp-docker-image-inventory-multi-arch:rzp-golden-image-base-golang-1.25-alpine3.22: - build/docker/Dockerfile (was golang:1.19.0-alpine3.16, 2 stages) - tests/mocksubscriber/docker/Dockerfile (was golang:1.16.5-alpine3.13) - Update CI container images in .github/workflows: - build.yml (2 occurrences, was golang:1.16.5-alpine3.13) - review_ci.yml (was golang:1.16.5-alpine3.13)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Org N-1 Go Migration
This PR upgrades the Go toolchain for the
metrorepo from Go 1.19 to Go 1.25, as part of the org-wide N-1 Go version migration initiative.Changes
godirective from1.19to1.25golang:x.y*base images with the standard internal imagec.rzp.io/razorpay/rzp-docker-image-inventory-multi-arch:rzp-golden-image-base-golang-1.25-alpine3.22:build/docker/Dockerfile— proto-builder and builder stages (wasgolang:1.19.0-alpine3.16)tests/mocksubscriber/docker/Dockerfile(wasgolang:1.16.5-alpine3.13).github/workflows/:build.yml— tests and integration-tests containers (wasgolang:1.16.5-alpine3.13)review_ci.yml— reviewdog container (wasgolang:1.16.5-alpine3.13)Local Verification
go mod edit -go=1.25applied successfullygo mod tidyis blocked by a pre-existing codegen breakage: missing generated packages (github.com/razorpay/metro/rpc/proto/v1,github.com/razorpay/metro/statik, variousmocks/*packages) that also fail on a clean checkout of master — these requiremake proto-generate mock-gento be run first.go.sumreverted to avoid half-written churn.go build ./...fails identically on both the upgrade branch and a clean master checkout (same pre-existing breakage: proto and statik packages not generated). CI is the gate once codegen runs.Notes
make deps proto-generate mock-genbefore building.🤖 Generated with Claude Code