Skip to content

Fix cleanAssetCatalog error #41865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
janicduplessis wants to merge 2 commits into from
Closed

Fix cleanAssetCatalog error #41865

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0876eeb
Fix cleanAssetCatalog
janicduplessis Dec 8, 2023
72558cf
Update assetCatalogIOS.js
janicduplessis Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/community-cli-plugin/src/commands/bundle/assetCatalogIOS.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ import fs from 'fs';
import path from 'path';

export function cleanAssetCatalog(catalogDir: string): void {
const files = fs
const imageSets = fs
.readdirSync(catalogDir)
.filter(file => file.endsWith('.imageset'));
for (const file of files) {
fs.rmSync(path.join(catalogDir, file));
.filter(imageSet => imageSet.endsWith('.imageset'));

@huntie huntie Dec 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It's inaccurate to rename this to imageSet within this filter call, given these are candidates within the search directory. Let's use file or fileOrDir (which in this case is technically a file, directory, or package).

(I also don't mind the previous generic naming of files for the outer variable — until there is a future need to remove multiple kinds of files differently.)

for (const imageSet of imageSets) {
fs.rmSync(path.join(catalogDir, imageSet), {recursive: true, force: true});
}
}

Expand Down