Skip to content

Make the sync subtitle delay feature intuitive #3160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fire-light42 merged 1 commit into from
Sep 23, 2026
Merged

Make the sync subtitle delay feature intuitive #3160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions app/src/main/java/com/lagradost/cloudstream3/ui/player/FullScreenPlayer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,12 @@ open class FullScreenPlayer : AbstractPlayerFragment<FragmentPlayerBinding>(
private var hideControlsNames = false
protected var subtitleDelay
set(value) = try {
player.setSubtitleOffset(-value)
player.setSubtitleOffset(value)
} catch (e: Exception) {
logError(e)
}
get() = try {
-player.getSubtitleOffset()
player.getSubtitleOffset()
} catch (e: Exception) {
logError(e)
0L
Expand Down Expand Up @@ -527,7 +527,7 @@ open class FullScreenPlayer : AbstractPlayerFragment<FragmentPlayerBinding>(

// Scroll to the first active subtitle
val playerPosition = player.getPosition() ?: 0
val totalPosition = playerPosition - currentOffset
val totalPosition = playerPosition + currentOffset
subtitleAdapter?.updateTime(totalPosition)

subtitleAdapter?.getLatestActiveItem(totalPosition)
Expand All @@ -537,11 +537,11 @@ open class FullScreenPlayer : AbstractPlayerFragment<FragmentPlayerBinding>(

val str = when {
time > 0L -> {
txt(R.string.subtitle_offset_extra_hint_later_format, time)
txt(R.string.subtitle_offset_extra_hint_before_format, time)
}

time < 0L -> {
txt(R.string.subtitle_offset_extra_hint_before_format, -time)
txt(R.string.subtitle_offset_extra_hint_later_format, -time)
}

else -> {
Expand All @@ -559,12 +559,12 @@ open class FullScreenPlayer : AbstractPlayerFragment<FragmentPlayerBinding>(
subtitleOffsetRecyclerview.isVisible = subtitles.isNotEmpty()
noSubtitlesLoadedNotice.isVisible = subtitles.isEmpty()

val initialSubtitlePosition = (player.getPosition() ?: 0) - currentOffset
val initialSubtitlePosition = (player.getPosition() ?: 0) + currentOffset
subtitleAdapter =
SubtitleOffsetItemAdapter(initialSubtitlePosition) { subtitleCue ->
val playerPosition = player.getPosition() ?: 0
subtitleOffsetInput.text = Editable.Factory.getInstance()
?.newEditable((playerPosition - subtitleCue.startTimeMs).toString())
?.newEditable((subtitleCue.startTimeMs - playerPosition).toString())
}.apply {
submitList(subtitles)
}
Expand Down