Skip to content

chore(quickstart): upgrade plugin to BS v1.54.6 #4682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
divyanshiGupta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(quickstart): upgrade plugin to BS v1.54.6 #4682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions workspaces/quickstart/.changeset/version-bump-1-54-6.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@red-hat-developer-hub/backstage-plugin-quickstart': minor
---

Backstage version bump to v1.54.6. Also bump `@red-hat-developer-hub/backstage-plugin-app-react` to `^1.0.0` (NFS exports moved off `/alpha`) and `@red-hat-developer-hub/backstage-plugin-global-header` to `^2.0.1` (`configSchema` blueprints) for `frontend-plugin-api` 0.18.0 compatibility.
2 changes: 1 addition & 1 deletion workspaces/quickstart/backstage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"version": "1.52.1"
"version": "1.54.6"
}
9 changes: 6 additions & 3 deletions workspaces/quickstart/e2e-tests/quick-start-admin-guest.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,12 @@ test.describe('Test Quick Start plugin', () => {
translations.steps.setupLightspeed.description,
);
await setupLightspeedDescription.waitFor({ state: 'visible' });
await expect(page.getByRole('list')).toContainText(
translations.steps.setupLightspeed.description,
);
// NFS catalog breadcrumbs are also role=list; target the quickstart step list.
await expect(
page.getByRole('list').filter({
hasText: translations.steps.setupLightspeed.description,
}),
).toBeVisible();
const setupLightspeedParentList = setupLightspeedDescription
.locator('..')
.locator('..')
Expand Down
16 changes: 8 additions & 8 deletions workspaces/quickstart/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@
"directory": "workspaces/quickstart"
},
"devDependencies": {
"@backstage/cli": "^0.36.3",
"@backstage/cli-defaults": "^0.1.3",
"@backstage/cli": "^0.36.5",
"@backstage/cli-defaults": "^0.1.5",
"@backstage/e2e-test-utils": "^0.1.2",
"@backstage/repo-tools": "^0.17.3",
"@backstage/repo-tools": "^0.19.0",
"@changesets/cli": "^2.27.1",
"@jest/environment-jsdom-abstract": "^30.3.0",
"@playwright/test": "1.61.1",
Expand All @@ -59,11 +59,11 @@
"typescript": "~5.8.0"
},
"resolutions": {
"@backstage/frontend-plugin-api": "0.17.2",
"@backstage/plugin-catalog-react": "3.1.0",
"@backstage/plugin-permission-react": "0.5.2",
"@backstage/plugin-signals-react": "0.0.23",
"@backstage/ui": "0.16.0",
"@backstage/frontend-plugin-api": "0.18.0",
"@backstage/plugin-catalog-react": "3.2.2",
"@backstage/plugin-permission-react": "0.5.4",
"@backstage/plugin-signals-react": "0.0.25",
"@backstage/ui": "0.17.1",
"@types/react": "^18",
"@types/react-dom": "^18",
"refractor@npm:3.6.0/prismjs": "^1.30.0"
Expand Down
50 changes: 25 additions & 25 deletions workspaces/quickstart/packages/app-legacy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,35 +20,35 @@
},
"dependencies": {
"@backstage-community/plugin-rbac": "^1.40.1",
"@backstage/app-defaults": "^1.7.9",
"@backstage/catalog-model": "^1.9.0",
"@backstage/cli": "^0.36.3",
"@backstage/core-app-api": "^1.20.2",
"@backstage/core-components": "^0.18.11",
"@backstage/core-plugin-api": "^1.12.7",
"@backstage/integration-react": "^1.2.19",
"@backstage/plugin-api-docs": "^0.14.2",
"@backstage/plugin-catalog": "^2.0.6",
"@backstage/app-defaults": "^1.7.11",
"@backstage/catalog-model": "^1.10.0",
"@backstage/cli": "^0.36.5",
"@backstage/core-app-api": "^1.20.4",
"@backstage/core-components": "^0.18.13",
"@backstage/core-plugin-api": "^1.12.9",
"@backstage/integration-react": "^1.2.21",
"@backstage/plugin-api-docs": "^0.14.4",
"@backstage/plugin-catalog": "^2.0.8",
"@backstage/plugin-catalog-common": "^1.1.10",
"@backstage/plugin-catalog-graph": "^0.6.5",
"@backstage/plugin-catalog-import": "^0.13.14",
"@backstage/plugin-catalog-react": "^3.1.0",
"@backstage/plugin-kubernetes": "^0.12.20",
"@backstage/plugin-org": "^0.7.5",
"@backstage/plugin-permission-react": "^0.5.2",
"@backstage/plugin-scaffolder": "^1.38.0",
"@backstage/plugin-search": "^1.7.5",
"@backstage/plugin-search-react": "^1.11.5",
"@backstage/plugin-techdocs": "^1.17.7",
"@backstage/plugin-techdocs-module-addons-contrib": "^1.1.37",
"@backstage/plugin-techdocs-react": "^1.3.12",
"@backstage/plugin-user-settings": "^0.9.4",
"@backstage/plugin-catalog-graph": "^0.6.7",
"@backstage/plugin-catalog-import": "^0.13.17",
"@backstage/plugin-catalog-react": "^3.2.2",
"@backstage/plugin-kubernetes": "^0.12.22",
"@backstage/plugin-org": "^0.7.8",
"@backstage/plugin-permission-react": "^0.5.4",
"@backstage/plugin-scaffolder": "^1.38.2",
"@backstage/plugin-search": "^1.7.7",
"@backstage/plugin-search-react": "^1.11.7",
"@backstage/plugin-techdocs": "^1.18.0",
"@backstage/plugin-techdocs-module-addons-contrib": "^1.1.39",
"@backstage/plugin-techdocs-react": "^1.3.14",
"@backstage/plugin-user-settings": "^0.9.6",
"@backstage/theme": "^0.7.3",
"@backstage/ui": "^0.16.0",
"@backstage/ui": "^0.17.1",
"@mui/icons-material": "5.18.0",
"@mui/material": "5.18.0",
"@mui/styles": "5.18.0",
"@red-hat-developer-hub/backstage-plugin-global-header": "1.21.5",
"@red-hat-developer-hub/backstage-plugin-global-header": "^2.0.1",
"@red-hat-developer-hub/backstage-plugin-quickstart": "workspace:^",
"@red-hat-developer-hub/backstage-plugin-theme": "^0.14.11",
"react": "^18.0.2",
Expand All @@ -58,7 +58,7 @@
},
"devDependencies": {
"@axe-core/playwright": "^4.10.0",
"@backstage/test-utils": "^1.7.19",
"@backstage/test-utils": "^1.7.21",
"@playwright/test": "1.61.1",
"@testing-library/dom": "^9.0.0",
"@testing-library/jest-dom": "^6.0.0",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/quickstart/packages/app-legacy/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ import { CatalogGraphPage } from '@backstage/plugin-catalog-graph';
import { RequirePermission } from '@backstage/plugin-permission-react';
import { catalogEntityCreatePermission } from '@backstage/plugin-catalog-common/alpha';
import { getAllThemes } from '@red-hat-developer-hub/backstage-plugin-theme';
import { quickstartTranslations } from '@red-hat-developer-hub/backstage-plugin-quickstart';
import { quickstartTranslations } from '@red-hat-developer-hub/backstage-plugin-quickstart/alpha';
import { githubAuthApiRef } from '@backstage/core-plugin-api';
import { RbacPage } from '@backstage-community/plugin-rbac';

Expand Down
2 changes: 1 addition & 1 deletion workspaces/quickstart/packages/app-legacy/src/components/Root/Root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ import { MyGroupsSidebarItem } from '@backstage/plugin-org';
import {
defaultGlobalHeaderComponentsMountPoints,
GlobalHeaderComponent,
} from '@red-hat-developer-hub/backstage-plugin-global-header';
} from '@red-hat-developer-hub/backstage-plugin-global-header/legacy';
import Box from '@mui/material/Box';
import {
QuickstartDrawerProvider,
Expand Down
50 changes: 25 additions & 25 deletions workspaces/quickstart/packages/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,32 +19,32 @@
"lint": "backstage-cli package lint"
},
"dependencies": {
"@backstage/cli": "^0.36.3",
"@backstage/core-components": "^0.18.11",
"@backstage/core-plugin-api": "^1.12.7",
"@backstage/frontend-defaults": "^0.5.3",
"@backstage/frontend-plugin-api": "^0.17.2",
"@backstage/integration-react": "^1.2.19",
"@backstage/plugin-api-docs": "^0.14.2",
"@backstage/plugin-app-react": "^0.2.4",
"@backstage/plugin-app-visualizer": "^0.2.5",
"@backstage/plugin-catalog": "^2.0.6",
"@backstage/plugin-catalog-graph": "^0.6.5",
"@backstage/plugin-catalog-import": "^0.13.14",
"@backstage/plugin-kubernetes": "^0.12.20",
"@backstage/plugin-notifications": "^0.5.18",
"@backstage/plugin-org": "^0.7.5",
"@backstage/plugin-scaffolder": "^1.38.0",
"@backstage/plugin-search": "^1.7.5",
"@backstage/plugin-signals": "^0.0.32",
"@backstage/plugin-techdocs": "^1.17.7",
"@backstage/plugin-techdocs-module-addons-contrib": "^1.1.37",
"@backstage/plugin-user-settings": "^0.9.4",
"@backstage/ui": "^0.16.0",
"@backstage/cli": "^0.36.5",
"@backstage/core-components": "^0.18.13",
"@backstage/core-plugin-api": "^1.12.9",
"@backstage/frontend-defaults": "^0.5.5",
"@backstage/frontend-plugin-api": "^0.18.0",
"@backstage/integration-react": "^1.2.21",
"@backstage/plugin-api-docs": "^0.14.4",
"@backstage/plugin-app-react": "^0.2.6",
"@backstage/plugin-app-visualizer": "^0.2.7",
"@backstage/plugin-catalog": "^2.0.8",
"@backstage/plugin-catalog-graph": "^0.6.7",
"@backstage/plugin-catalog-import": "^0.13.17",
"@backstage/plugin-kubernetes": "^0.12.22",
"@backstage/plugin-notifications": "^0.5.20",
"@backstage/plugin-org": "^0.7.8",
"@backstage/plugin-scaffolder": "^1.38.2",
"@backstage/plugin-search": "^1.7.7",
"@backstage/plugin-signals": "^0.0.34",
"@backstage/plugin-techdocs": "^1.18.0",
"@backstage/plugin-techdocs-module-addons-contrib": "^1.1.39",
"@backstage/plugin-user-settings": "^0.9.6",
"@backstage/ui": "^0.17.1",
"@mui/icons-material": "5.18.0",
"@mui/material": "5.18.0",
"@red-hat-developer-hub/backstage-plugin-app-react": "^0.1.0",
"@red-hat-developer-hub/backstage-plugin-global-header": "^2.0.0",
"@red-hat-developer-hub/backstage-plugin-app-react": "^1.0.0",
"@red-hat-developer-hub/backstage-plugin-global-header": "^2.0.1",
"@red-hat-developer-hub/backstage-plugin-quickstart": "workspace:^",
"@red-hat-developer-hub/backstage-plugin-theme": "^0.14.11",
"material-icons": "^1.13.14",
Expand All @@ -54,7 +54,7 @@
"react-router-dom": "^6.30.2"
},
"devDependencies": {
"@backstage/frontend-test-utils": "^0.6.1",
"@backstage/frontend-test-utils": "^0.6.3",
"@playwright/test": "1.61.1",
"@testing-library/dom": "^9.0.0",
"@testing-library/jest-dom": "^6.0.0",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/quickstart/packages/app/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/
import { createApp } from '@backstage/frontend-defaults';
import { appDrawerModule } from '@red-hat-developer-hub/backstage-plugin-app-react/alpha';
import { appDrawerModule } from '@red-hat-developer-hub/backstage-plugin-app-react';
import {
globalHeaderModule,
globalHeaderTranslationsModule,
Expand Down
48 changes: 24 additions & 24 deletions workspaces/quickstart/packages/backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,37 +22,37 @@
},
"dependencies": {
"@backstage-community/plugin-rbac-backend": "^7.4.0",
"@backstage/backend-defaults": "^0.17.4",
"@backstage/backend-defaults": "^0.17.8",
"@backstage/config": "^1.3.8",
"@backstage/plugin-app-backend": "^0.5.15",
"@backstage/plugin-auth-backend": "^0.29.2",
"@backstage/plugin-auth-backend-module-github-provider": "^0.5.4",
"@backstage/plugin-auth-backend-module-guest-provider": "^0.2.20",
"@backstage/plugin-auth-node": "^0.7.2",
"@backstage/plugin-catalog-backend": "^3.8.0",
"@backstage/plugin-catalog-backend-module-logs": "^0.1.23",
"@backstage/plugin-catalog-backend-module-scaffolder-entity-model": "^0.2.21",
"@backstage/plugin-kubernetes-backend": "^0.21.5",
"@backstage/plugin-permission-backend": "^0.7.13",
"@backstage/plugin-permission-backend-module-allow-all-policy": "^0.2.20",
"@backstage/plugin-permission-common": "^0.9.9",
"@backstage/plugin-permission-node": "^0.11.1",
"@backstage/plugin-proxy-backend": "^0.6.14",
"@backstage/plugin-scaffolder-backend": "^4.0.1",
"@backstage/plugin-scaffolder-backend-module-github": "^0.9.10",
"@backstage/plugin-search-backend": "^2.1.3",
"@backstage/plugin-search-backend-module-catalog": "^0.3.16",
"@backstage/plugin-search-backend-module-pg": "^0.5.56",
"@backstage/plugin-search-backend-module-techdocs": "^0.4.15",
"@backstage/plugin-search-backend-node": "^1.4.5",
"@backstage/plugin-techdocs-backend": "^2.2.1",
"@backstage/plugin-app-backend": "^0.5.17",
"@backstage/plugin-auth-backend": "^0.30.0",
"@backstage/plugin-auth-backend-module-github-provider": "^0.5.6",
"@backstage/plugin-auth-backend-module-guest-provider": "^0.2.22",
"@backstage/plugin-auth-node": "^0.7.4",
"@backstage/plugin-catalog-backend": "^3.9.1",
"@backstage/plugin-catalog-backend-module-logs": "^0.1.25",
"@backstage/plugin-catalog-backend-module-scaffolder-entity-model": "^0.2.23",
"@backstage/plugin-kubernetes-backend": "^0.21.10",
"@backstage/plugin-permission-backend": "^0.7.15",
"@backstage/plugin-permission-backend-module-allow-all-policy": "^0.2.22",
"@backstage/plugin-permission-common": "^0.9.10",
"@backstage/plugin-permission-node": "^0.11.3",
"@backstage/plugin-proxy-backend": "^0.6.17",
"@backstage/plugin-scaffolder-backend": "^4.1.0",
"@backstage/plugin-scaffolder-backend-module-github": "^0.9.13",
"@backstage/plugin-search-backend": "^2.1.6",
"@backstage/plugin-search-backend-module-catalog": "^0.3.18",
"@backstage/plugin-search-backend-module-pg": "^0.5.58",
"@backstage/plugin-search-backend-module-techdocs": "^0.4.17",
"@backstage/plugin-search-backend-node": "^1.4.7",
"@backstage/plugin-techdocs-backend": "^2.2.4",
"app": "link:../app",
"better-sqlite3": "^12.0.0",
"node-gyp": "^10.0.0",
"pg": "^8.11.3"
},
"devDependencies": {
"@backstage/cli": "^0.36.3"
"@backstage/cli": "^0.36.5"
},
"files": [
"dist"
Expand Down
2 changes: 1 addition & 1 deletion workspaces/quickstart/plugins/quickstart/dev/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@

import WavingHandOutlinedIcon from '@mui/icons-material/WavingHandOutlined';

import { useAppDrawer } from '@red-hat-developer-hub/backstage-plugin-app-react';

Check warning on line 45 in workspaces/quickstart/plugins/quickstart/dev/index.tsx

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'@red-hat-developer-hub/backstage-plugin-app-react' imported multiple times. 


See more on https://sonarcloud.io/project/issues?id=redhat-developer_rhdh-plugins&issues=AaCKgPCoYPm1NfnETVAN&open=AaCKgPCoYPm1NfnETVAN&pullRequest=4682
import { appDrawerModule } from '@red-hat-developer-hub/backstage-plugin-app-react/alpha';
import { appDrawerModule } from '@red-hat-developer-hub/backstage-plugin-app-react';

Check warning on line 46 in workspaces/quickstart/plugins/quickstart/dev/index.tsx

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'@red-hat-developer-hub/backstage-plugin-app-react' imported multiple times. 


See more on https://sonarcloud.io/project/issues?id=redhat-developer_rhdh-plugins&issues=AaCKgPCoYPm1NfnETVAO&open=AaCKgPCoYPm1NfnETVAO&pullRequest=4682
import { rhdhThemeModule } from '@red-hat-developer-hub/backstage-plugin-theme/alpha';

import quickstartPlugin, {
Expand Down
26 changes: 13 additions & 13 deletions workspaces/quickstart/plugins/quickstart/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,17 @@
},
"dependencies": {
"@backstage-community/plugin-rbac-common": "^1.19.0",
"@backstage/core-components": "^0.18.11",
"@backstage/core-plugin-api": "^1.12.7",
"@backstage/frontend-plugin-api": "^0.17.2",
"@backstage/plugin-app-react": "^0.2.4",
"@backstage/plugin-permission-react": "^0.5.2",
"@backstage/core-components": "^0.18.13",
"@backstage/core-plugin-api": "^1.12.9",
"@backstage/frontend-plugin-api": "^0.18.0",
"@backstage/plugin-app-react": "^0.2.6",
"@backstage/plugin-permission-react": "^0.5.4",
"@backstage/theme": "^0.7.3",
"@mui/icons-material": "5.18.0",
"@mui/material": "5.18.0",
"@patternfly/react-icons": "^6.5.0",
"@red-hat-developer-hub/backstage-plugin-app-react": "^0.1.0",
"@red-hat-developer-hub/backstage-plugin-global-header": "^2.0.0",
"@red-hat-developer-hub/backstage-plugin-app-react": "^1.0.0",
"@red-hat-developer-hub/backstage-plugin-global-header": "^2.0.1",
"@red-hat-developer-hub/backstage-plugin-theme": "^0.14.11",
"react-use": "^17.6.0"
},
Expand All @@ -56,12 +56,12 @@
"react-router-dom": "^6.0.0"
},
"devDependencies": {
"@backstage/cli": "^0.36.3",
"@backstage/core-app-api": "^1.20.2",
"@backstage/dev-utils": "^1.1.24",
"@backstage/frontend-defaults": "^0.5.3",
"@backstage/plugin-permission-common": "^0.9.9",
"@backstage/test-utils": "^1.7.19",
"@backstage/cli": "^0.36.5",
"@backstage/core-app-api": "^1.20.4",
"@backstage/dev-utils": "^1.1.26",
"@backstage/frontend-defaults": "^0.5.5",
"@backstage/plugin-permission-common": "^0.9.10",
"@backstage/test-utils": "^1.7.21",
"@testing-library/jest-dom": "^6.0.0",
"@testing-library/react": "^14.0.0",
"@testing-library/user-event": "^14.0.0",
Expand Down
Loading
Loading