fix(#4717): add LICENSE_FILE_EXISTS mock to homepage aggregations - #4718
Merged
Merged
Conversation
mockAllDefaultHomepageAggregationsSuccess mocked 5 of 6 KPI aggregation routes but omitted the LICENSE_FILE_EXISTS route. Add licenseFileExistsAggregatedResponse import and mockApiResponse call so all 6 routes in AGGREGATED_CARDS_METRIC_IDS are mocked. Closes #4717
fullsend-ai-coder
Bot
requested review from
a team,
Eswaraiahsapram,
christoph-jerolimov and
its-mitesh-kumar
as code owners
September 14, 2026 08:44
Changed Packages
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4718 +/- ##
=======================================
Coverage 62.72% 62.72%
=======================================
Files 2636 2636
Lines 105422 105422
Branches 29529 29529
=======================================
Hits 66125 66125
Misses 37495 37495
Partials 1802 1802
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
🤖 Finished Review · ✅ Success · Started 8:46 AM UTC · Completed 8:52 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $1.47 |
|
Review — ApprovePR: #4718 — fix(#4717): add LICENSE_FILE_EXISTS mock to homepage aggregations SummaryClean, minimal bug fix that adds the missing 6th mock to The fix:
Dimensions reviewed
No findings. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
imykhno
approved these changes
Sep 14, 2026
|
🤖 Finished Retro · ✅ Success · Started 9:43 AM UTC · Completed 9:55 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.87 |
PR #4718 Retro SummaryPR #4718 was a clean, single-iteration workflow that demonstrates the retro-to-fix pipeline working as designed. Timeline
Total pipeline cost: ~$3.66 | Total time: ~77 minutes (issue to merge) Workflow Quality
Supporting Evidence for Existing Issues
ProposalsOne proposal filed — review agent should escalate findings that persist across multiple review passes. Proposals skipped (target repo not allowed)File manually or update
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mockAllDefaultHomepageAggregationsSuccess mocked 5 of 6 KPI aggregation routes but omitted the LICENSE_FILE_EXISTS route. Add licenseFileExistsAggregatedResponse import and mockApiResponse call so all 6 routes in AGGREGATED_CARDS_METRIC_IDS are mocked.
Closes #4717
Post-script verification
agent/4717-add-license-file-exists-mock)e788230460696968eaa223ca692500d09ea52879..HEAD)