-
Notifications
You must be signed in to change notification settings - Fork 24
Add configurable ioThreads to Linux and Windows ODF VM workloads #1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -97,7 +97,7 @@ spec: | |
| efi: | ||
| secureBoot: false | ||
| ioThreads: | ||
| supplementalPoolThreadCount: 8 | ||
| supplementalPoolThreadCount: {{ supplementalPoolThreadCount }} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- target template ---'
cat -n benchmark_runner/common/template_operations/templates/winmssql/internal_data/winmssql_vm_template.yaml | sed -n '85,110p'
printf '%s\n' '--- matching data templates ---'
fd -i 'winmssql.*data.*template.*\.ya?ml$' benchmark_runner/common/template_operations/templates || true
printf '%s\n' '--- all references to supplementalPoolThreadCount and WORKLOAD_CONFIG ---'
rg -n -C 4 'supplementalPoolThreadCount|WORKLOAD_CONFIG' benchmark_runner/common/template_operations
printf '%s\n' '--- winmssql template files ---'
find benchmark_runner/common/template_operations/templates/winmssql -maxdepth 3 -type f -printRepository: redhat-performance/benchmark-runner Length of output: 22944 🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- winmssql data template ---'
cat -n benchmark_runner/common/template_operations/templates/winmssql/winmssql_data_template.yaml
printf '%s\n' '--- override loading and rendering contract ---'
cat -n benchmark_runner/common/template_operations/template_operations.py | sed -n '120,195p'
printf '%s\n' '--- WORKLOAD_CONFIG definitions and parsing ---'
rg -n -C 5 'WORKLOAD_CONFIG|workload_config' benchmark_runner tests | head -240Repository: redhat-performance/benchmark-runner Length of output: 13020 🌐 Web query:
💡 Result: In KubeVirt, the supplementalPool policy is an option for the ioThreadsPolicy setting that allows users to define a custom pool of IOThreads for a Virtual Machine [1][2]. The supplementalPoolThreadCount field is used to specify the number of IOThreads in this pool [1][3]. Key details regarding the configuration and schema: 1. Data Type: The supplementalPoolThreadCount field accepts a positive integer representing the number of IOThreads to be allocated [4]. 2. Configuration Example: The field is defined under the ioThreads structure within the VM domain specification [1][2]: spec: domain: ioThreadsPolicy: supplementalPool ioThreads: supplementalPoolThreadCount: 4 3. Functionality: This policy enables users to control the number of IOThreads independently of vCPUs, which helps improve performance for I/O-intensive workloads [2][3]. When supplementalPool is enabled, the specified number of threads is added to the pod's total CPU requirements, as these threads consume additional host resources [4][3]. 4. Recommendations: Performance measurements suggest that an optimal number of IOThreads typically falls between 4 and 8, depending on the specific workload [1][2]. This feature was introduced to address sub-optimal default IOThread calculations and allows for better scalability on SMP systems [2]. When dedicatedCpuPlacement is enabled, these IOThreads are pinned to dedicated physical CPUs to prevent interference with vCPU threads [1][2]. Citations:
Validate Both 🤖 Prompt for AI Agents |
||
| ioThreadsPolicy: supplementalPool | ||
| machine: | ||
| type: q35 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Align HammerDB default supplemental thread counts with the stated objective.
The PR documents
io_threads: 8for all HammerDB VM workloads, but this template resolvesdefaultconfigurations tosupplementalPoolThreadCount: 2and only uses8forperf_ci. The affectedtest_cigenerated goldens therefore render2instead of8. Update the template and regenerate the affected golden files.📍 Affects 2 files
benchmark_runner/common/template_operations/templates/hammerdb/hammerdb_data_template.yaml#L88-L88(this comment)tests/unittest/benchmark_runner/common/template_operations/golden_files/test_ci_hammerdb_vm_postgres_lso_ODF_PVC_True/hammerdb_vm_postgres.yaml#L116-L116🤖 Prompt for AI Agents