Disallow RPM upload with the same NVR [RHELDST-37824]#403
Draft
rbikar wants to merge 2 commits into
Draft
Conversation
rbikar
force-pushed
the
disallowe-rpm-dupes
branch
3 times, most recently
from
562d78c to
aaca11a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #403 +/- ##
==========================================
- Coverage 99.80% 99.76% -0.04%
==========================================
Files 54 54
Lines 3018 3033 +15
==========================================
+ Hits 3012 3026 +14
- Misses 6 7 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rbikar
force-pushed
the
disallowe-rpm-dupes
branch
from
aaca11a to
3bcbfda
Compare
This change introduces a functionality that will raise a fatal error when upload of an RPM with NVR of already present unit in pulp. The RPMs in question differ only with their checksums (and signing keys), further association to live repositories and publish will cause breakage of repository. Duplicates check is by default disabled, and can be enabled by setting PUBTOOLS_PULP_ALLOW_DUPLICATE_UNITS env var. This should be a workaround until proper suport for sucvh scenario is implemented.
rbikar
force-pushed
the
disallowe-rpm-dupes
branch
from
c80112b to
cab454d
Compare
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a functionality that will raise a fatal error when upload of an RPM with NVR of already present unit in pulp.
The RPMs in question differ only with their checksums (and signing keys), further association to live repositories and publish will cause breakage of repository.
Duplicates check is by default disabled, and can be enabled by setting PUBTOOLS_PULP_ALLOW_DUPLICATE_UNITS env var.
This should be a workaround until proper suport for sucvh scenario is implemented.