@remotion/studio: Derive timeline selection order#8546
Merged
Conversation
Contributor
There was a problem hiding this comment.
Reviewed changes — replaces imperative registerSelectableItem with a tree-derived getSelectableTimelineItems that computes the ordered selectable timeline list from the visible tree structure rather than DOM mount order.
- Replace
registerSelectableItemwithsetSelectableTimelineItems— theTimelineSelectionProvidernow holds a single mutable ref set byTimelineSelectableItems, removing individual registration fromuseTimelineRowSelection,useTimelineKeyframeSelection,useTimelineEasingSelection, anduseTimelineGuideSelection. - Add
getSelectableTimelineItems— derives the full ordered list (sequences, props, easings, keyframes) from the timeline tree viabuildTimelineTree→filterTimelineExpandedTree→flattenVisibleTreeNodes, with keyframe/easing inclusion gated ongetNodeHasKeyframesandgetTimelineTreeNodeCanEditEasing. - Add regression test — validates expanded timeline item order: sequence → prop → easing → keyframes.
DeepSeek Pro (free via Pullfrog for OSS) | 𝕏
a858979 to
f6fdaf1
Compare
f6fdaf1 to
f0cc82f
Compare
f0cc82f to
1eceb8f
Compare
1eceb8f to
bcceeb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes #8540
Testing