Repository navigation
fix(web): preserve IME input in voice-tag controls - #550
Merged
Merged
Conversation
Owner
|
Thanks for the PR and test cases! Also opened #556 for the same issue noticed in the TextEditor find/replace inputs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enter used to confirm an IME composition also creates a voice tag or commits its rename; Enter/Escape in voice search closes the dropdown mid-composition. Ignore composing key events in those three handlers and preserve their normal keyboard actions afterward.
Added three regression cases covering creation, rename, and search; all fail on the original handlers. Validation:
npm run test:web(113 passed),npm run test:e2e -- --reporter=line(41 passed), andgit diff --check. A Chromium check with synthetic composing key events also confirmed that composing Enter leaves the cast unchanged and the following ordinary Enter creates the tag. Backend calls were mocked; no TTS inference was performed.