Repository navigation
fix(dev): return every segment from /dev/phonemize - #569
Merged
Merged
Conversation
The route returned from inside its pipeline loop, so text the pipeline split into several segments, such as separate paragraphs, came back with only the first segment's phonemes and no sign the rest was dropped. Join all segments with a space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The route returned from inside its pipeline loop, so text the pipeline
split into several segments, such as separate paragraphs, came back with
only the first segment's phonemes and no sign the rest was dropped.
Join all segments with a space.
Testing
pytest: full suite passes.test_phonemize_returns_every_segmentstubs a pipeline yielding two segments; it fails on master and passes here.docker/gpu/Dockerfile.optimizedwith this and the sibling PRs merged:/dev/phonemizewith"Hello there.\n\nGood morning."returns both sentences' phonemes.Follows #562-#568 from the same review. Based on master on its own; the only overlap with those PRs is the CHANGELOG
[Unreleased]section.