Repository navigation
fix(api): reject a download_format that differs from response_format - #570
Merged
Merged
Conversation
The download link file is written from the bytes encoded for response_format; download_format only changed its extension and so its served content type. mp3 with a wav download gave mp3 data named .wav, which strict players and importers refuse. Nothing re-encodes, so require the two to match (or download_format to be unset) on the speech and dialogue requests. The web player already sends the same value for both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The download link file is written from the bytes encoded for
response_format; download_format only changed its extension and so its
served content type. mp3 with a wav download gave mp3 data named .wav,
which strict players and importers refuse.
Nothing re-encodes, so require the two to match (or download_format to
be unset) on the speech and dialogue requests. The web player already
sends the same value for both.
Testing
pytest: full suite passes.test_download_format_*intest_request_bounds.pycover the speech and dialogue requests; the rejection test fails on master.AudioService.buildRequestBody), so it is unaffected.docker/gpu/Dockerfile.optimizedwith this and the sibling PRs merged: mp3 with a wav download returns 422, and mp3 with an mp3 download still streams with itsX-Download-Path.Follows #562-#568 from the same review. Based on master on its own; the only overlap with those PRs is the CHANGELOG
[Unreleased]section.