[deps] Dependency update: go - #6073
Open
replicated-software-factory[bot] wants to merge 4 commits into
Open
replicated-software-factory[bot] wants to merge 4 commits into
replicated-software-factory[bot] wants to merge 4 commits into
Conversation
|
ElasticClaw Factory seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
xavpaice
requested changes
Sep 26, 2026
| await login(page); | ||
| await uploadLicense(page, expect); | ||
| await expect(page.locator('#app')).toContainText('Configure No Required Config', { timeout: 15000 }); | ||
| await expect(page.locator('#app')).toContainText('Configure No Required Config', { timeout: 120000 }); |
Member
There was a problem hiding this comment.
I'd want more evidence for increasing this timeout, there are many flakey tests in this repo and increasing timeouts that are already long doesn't solve that.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates the Go dependency graph, including Open Policy Agent from v1.20.2 to v1.21.0.
Which issue(s) this PR fixes:
NONE
Does this PR require a test?
Yes.
go mod tidy -diffpasses andgo test ./pkg/rbacpasses.go test ./pkg/lint/validatorscurrently fails to compile: OPA v1.21.0 upgradesgithub.com/gobwas/globto v1.0.0, which removesglob.Glob, still referenced by pinnedgithub.com/replicatedhq/troubleshootv0.134.1. This environment also lackspkg-configand btrfs headers needed by other dependencies.Does this PR require a release note?
NONE
Does this PR require documentation?
NONE