Repository navigation
Filters part 5: Grid and Radial Patterns - #94
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…pport to SelectTool via DragState
…id selection inspector
…ate immediately shown
…dial filter center point
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds two new filter types (
PatternGridFilter/PatternRadialFilter), which allows a shape to be repeated!All filters are now out of beta.
Grid
The grid pattern repeats a region. A box marks the region. The shape inside is copied across and down. Two by two is the start. You can ask for more copies in the inspector.
Radial
The radial pattern repeats a slice. Imagine a pie. One slice of it holds the shape. The slice is copied around the center. A circle of copies forms, like a sunburst. Open lines close themselves to join the copies - see the blue shape in the image above for an example of this.
Frame
A new component was added and is included alongside
FilterComponentinPatternGridFilters calledFrameComponent. A frame is just a box on the sheet. You can drag it. You can resize it by its edges and corners. Alt and shift change the resize rules. This is currently only used by the grid pattern filter but the plan is for it to be used also by future bits of functionality like groups and symbols (#31).Three new tools were added - "Grid Pattern" and "Radial Pattern" make the respective new filter types. The old tools got new names. Fillet became FilletFilter. Chamfer became ChamferFilter. Mirror became MirrorFilter. The change in name is the change in code: these are filter tools now.
Selection outline
Selection got a new outline. It wraps the render shapes for a geometry, not just the source - see the light blue outline in the above image. Frames draw key point handles on their corners.
Snapping reached the new edges. The grid lines snap. The radial slice edges snap. The mirror line snaps.
Patterns save and load. History tracks their changes. The render code was split into smaller functions. Each filter type handles its own drawing.
Tests grew to cover it all. A pattern test with four hundred lines appeared. A frame test appeared too. The select tool test grew again.