12965 add passwordless config in db - #112
Closed
giregk wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Adds database-level configuration to support passwordless auth and adjusts the bank config API payload in support of updated SSO behavior.
Changes:
- Adds
uses_passwordless_authtoallowed_emailsandms_entra_vaults_use_passwordless_authtobanksvia a new migration. - Drops
bank_sso_config.is_sso_v2and removes it from thesso_configsJSON payload. - Introduces a new top-level
usesSsoV2field ingetBankConfigresponse (currently hard-coded).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/api2/routes/bank/getBankConfig.ts | Updates bank config response shape by removing is_sso_v2 from SSO configs and adding a new usesSsoV2 flag. |
| migrations/2026-07-28_14-11-47_sso_passwordless.js | Adds passwordless-related columns and removes the is_sso_v2 column from bank_sso_config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
See #113 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ticket https://github.com/rgsystemes/kb/issues/12965