Skip to content

fix: cloud editing welcome page edge cases#9623

Open
AdityaHegde wants to merge 1 commit into
mainfrom
fix/cloud-editing-welcome-edge-cases
Open

fix: cloud editing welcome page edge cases#9623
AdityaHegde wants to merge 1 commit into
mainfrom
fix/cloud-editing-welcome-edge-cases

Conversation

@AdityaHegde

Copy link
Copy Markdown
Collaborator
  1. Fix edit and rename icons not changing based on light/dark themes. Color was not correctly set.
  2. Fix Skip and view project not redirecting to edit. There was a race condition in setting state.
  3. Fix initial model creation erroring out. Bump the retry count and do a exponential wait when controller is restarting.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@AdityaHegde AdityaHegde requested a review from k-anshul June 29, 2026 13:44
@nishantmonu51

Copy link
Copy Markdown
Collaborator

@codex: review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 3637894354

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@nishantmonu51 nishantmonu51 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants