Add diagnostics to help users know when to insert typealias:#323
Draft
virtuald wants to merge 20 commits into
Draft
Add diagnostics to help users know when to insert typealias:#323virtuald wants to merge 20 commits into
virtuald wants to merge 20 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The result is that lines like the following get inserted into the various autogenerated files:
If XXX fails to resolve then the compiler error is hopefully a little more helpful, but maybe at the expense of additional symbols in the binary (maybe we can tell the compiler to not export it?)
However, if we were smarter about using namespaces in semiwrap, perhaps some of this wouldn't be needed.
Currently this is 100% slop and I haven't manually reviewed it yet. However, it can build mostrobotpy in its current state, so that implies it's not totally broken?