Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { MockedProvider } from '@apollo/client/testing';
import { fireEvent, render, screen } from '@testing-library/react';
import { fireEvent, render, screen, within } from '@testing-library/react';
import React from 'react';
import { MemoryRouter } from 'react-router-dom';

Expand Down Expand Up @@ -103,3 +103,119 @@ describe('MergedReportsComponent invalidation actions', () => {
).not.toBeInTheDocument();
});
});

const sortableReportHistory = [
{
reportId: 'sort_primary',
reportedAt: '2026-03-01T12:00:00Z',
policyId: null,
reason: 'Primary',
reporterId: null,
},
{
reportId: 'sort_zeta',
reportedAt: '2026-01-02T00:00:00Z',
policyId: 'policy_zeta',
reason: 'Bravo',
reporterId: { id: 'charlie', typeId: 'user_type' },
},
{
reportId: 'sort_beta',
reportedAt: '2025-12-30T00:00:00Z',
policyId: 'policy_beta',
reason: 'Charlie',
reporterId: { id: 'alpha', typeId: 'user_type' },
},
{
reportId: 'sort_alpha',
reportedAt: '2026-02-01T12:00:00Z',
policyId: 'policy_alpha',
reason: 'Alpha',
reporterId: { id: 'bravo', typeId: 'user_type' },
},
];

const sortingMocks = [
{
request: {
query: GQLGetUserItemsDocument,
variables: {
itemIdentifiers: [
{ id: 'charlie', typeId: 'user_type' },
{ id: 'alpha', typeId: 'user_type' },
{ id: 'bravo', typeId: 'user_type' },
],
},
},
result: { data: { latestItemSubmissions: [] } },
},
{
request: { query: GQLPoliciesDocument },
result: {
data: {
myOrg: {
id: 'org',
__typename: 'Org',
policies: [
{ id: 'policy_zeta', name: 'Zeta Policy', __typename: 'Policy' },
{ id: 'policy_beta', name: 'Beta Policy', __typename: 'Policy' },
{ id: 'policy_alpha', name: 'Alpha Policy', __typename: 'Policy' },
],
},
},
},
},
];

function renderedReasons() {
return within(screen.getAllByRole('rowgroup')[1])
.getAllByRole('row')
.map((row) => within(row).getAllByRole('cell')[2].textContent);
}

describe('MergedReportsComponent sorting', () => {
it.each([
[
'Reported By',
['Charlie', 'Alpha', 'Bravo'],
['Bravo', 'Alpha', 'Charlie'],
],
[
'Reported For',
['Alpha', 'Charlie', 'Bravo'],
['Bravo', 'Charlie', 'Alpha'],
],
['Reason', ['Alpha', 'Bravo', 'Charlie'], ['Charlie', 'Bravo', 'Alpha']],
[
'Report Time',
['Charlie', 'Bravo', 'Alpha'],
['Alpha', 'Bravo', 'Charlie'],
],
])(
'sorts %s by visible semantics in ascending and descending order',
async (header, ascending, descending) => {
render(
<MemoryRouter>
<MockedProvider
mocks={sortingMocks}
defaultOptions={{ watchQuery: { fetchPolicy: 'no-cache' } }}
>
<MergedReportsComponent
primaryReportId="sort_primary"
reportHistory={sortableReportHistory}
/>
</MockedProvider>
</MemoryRouter>,
);
fireEvent.click(screen.getByRole('button', { name: /show/i }));
await screen.findByText('Zeta Policy');

const columnHeader = screen.getByRole('columnheader', { name: header });
fireEvent.click(columnHeader);
expect(renderedReasons()).toEqual(ascending);

fireEvent.click(columnHeader);
expect(renderedReasons()).toEqual(descending);
},
);
});
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { ChevronDown, ChevronUp, ExternalLink } from 'lucide-react';
import { useCallback, useMemo, useState } from 'react';
import { Link } from 'react-router-dom';

import { dateSort, stringSort } from '../../components/table/sort';
import Table from '../../components/table/Table';

import InvalidateReportsButton from './InvalidateReportsButton';
Expand Down Expand Up @@ -103,10 +104,30 @@ export default function MergedReportsComponent(props: {

const columns = useMemo(
() => [
{ header: 'Reported By', accessorKey: 'reportedBy' },
{ header: 'Reported For', accessorKey: 'reportedFor' },
{ header: 'Reason', accessorKey: 'reason' },
{ header: 'Report Time', accessorKey: 'reportTime' },
{
header: 'Reported By',
accessorKey: 'reportedBy',
sortFn: stringSort,
sortDescFirst: false,
},
{
header: 'Reported For',
accessorKey: 'reportedFor',
sortFn: stringSort,
sortDescFirst: false,
},
{
header: 'Reason',
accessorKey: 'reason',
sortFn: stringSort,
sortDescFirst: false,
},
{
header: 'Report Time',
accessorKey: 'reportTime',
sortFn: dateSort('reportTime'),
sortDescFirst: false,
},
],
[],
);
Expand Down Expand Up @@ -141,6 +162,8 @@ export default function MergedReportsComponent(props: {
hasReporter && report.displayInfo?.typeName
? `${report.displayInfo.typeName}: `
: '';
const reportedFor = policy?.name ?? '—';
const reason = report.reason?.trim() || '—';
return {
reportedBy: (
<div className="flex flex-wrap items-center gap-x-2">
Expand Down Expand Up @@ -204,6 +227,12 @@ export default function MergedReportsComponent(props: {
reportTime: parseDatetimeToReadableStringInCurrentTimeZone(
report.reportedAt,
),
values: {
reportedBy: `${reportedByPrefix}${reportedByLabel}`,
reportedFor,
reason,
reportTime: report.reportedAt,
},
};
});
}, [
Expand Down
Loading