Skip to content

Fix review options select value - #1005

Closed
taobojlen wants to merge 1 commit into
mainfrom
fix/review-options-select-value
Closed

Fix review options select value#1005
taobojlen wants to merge 1 commit into
mainfrom
fix/review-options-select-value

Conversation

@taobojlen

Copy link
Copy Markdown
Contributor

Context & Requests for Reviewers

Tests

(Optional) Rollout Plan

Checklist

Only check items that apply to this PR; leave the rest unchecked.

  • If you changed anything user-facing (i.e. user interface or APIs):
    Did you update the CHANGELOG.md and related docs?

  • If you changed server/models/**/{ContentTypeModel,ActionModel,RuleModel,PolicyModel}.ts:
    Did you update the corresponding history tables and their triggers?

  • If you changed db/src/scripts/** and used CREATE TABLE, ADD COLUMN, or ALTER COLUMN:
    Are as many columns marked NOT NULL as possible? If some columns can sometimes be null depending on other columns, are there CHECK constraints capturing those relationships, and are these also reflected using unions in the associated Kysely types?

  • If you added a new signal in server/services/signalsService/signals/**:
    Did you classify every error case as a permanent error (SignalPermanentError, no retry) or a normal error (retryable)? Any case where the signal can't determine a score should be a SignalPermanentError.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f964e4bb-726a-403d-97d5-094159a52a6a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@taobojlen
taobojlen force-pushed the fix/review-policy-select-value branch from 93d41c5 to 2d4f946 Compare August 12, 2026 03:05
@taobojlen
taobojlen force-pushed the fix/review-options-select-value branch from 300f51c to ada67e0 Compare August 12, 2026 03:05
@taobojlen
taobojlen force-pushed the fix/review-policy-select-value branch from 2d4f946 to 63688f9 Compare August 12, 2026 03:42
@taobojlen
taobojlen force-pushed the fix/review-options-select-value branch from ada67e0 to 8d81b9f Compare August 12, 2026 03:42
@taobojlen
taobojlen force-pushed the fix/review-policy-select-value branch from 63688f9 to fcad105 Compare August 17, 2026 10:22
@taobojlen
taobojlen force-pushed the fix/review-options-select-value branch from 8d81b9f to e64ee27 Compare August 17, 2026 10:22
@taobojlen
taobojlen changed the base branch from fix/review-policy-select-value to main August 17, 2026 10:23
@taobojlen taobojlen closed this Aug 18, 2026
@taobojlen
taobojlen deleted the fix/review-options-select-value branch August 18, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant