Skip to content

Fix manual review pie legend toggling - #1010

Open
taobojlen wants to merge 1 commit into
mainfrom
fix/manual-review-pie-legend
Open

Fix manual review pie legend toggling#1010
taobojlen wants to merge 1 commit into
mainfrom
fix/manual-review-pie-legend

Conversation

@taobojlen

@taobojlen taobojlen commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Context & Requests for Reviewers

Fixes a small bug on e.g. /dashboard/manual_review/analytics. If you showed a pie chart, then toggling a series from the legend would not actually hide it from the pie chart like you'd expect. This PR fixes that.

Tests

Tested manually and added a unit test.

(Optional) Rollout Plan

N/A

Checklist

Only check items that apply to this PR; leave the rest unchecked.

  • If you changed anything user-facing (i.e. user interface or APIs):
    Did you update the CHANGELOG.md and related docs?

  • If you changed server/models/**/{ContentTypeModel,ActionModel,RuleModel,PolicyModel}.ts:
    Did you update the corresponding history tables and their triggers?

  • If you changed db/src/scripts/** and used CREATE TABLE, ADD COLUMN, or ALTER COLUMN:
    Are as many columns marked NOT NULL as possible? If some columns can sometimes be null depending on other columns, are there CHECK constraints capturing those relationships, and are these also reflected using unions in the associated Kysely types?

  • If you added a new signal in server/services/signalsService/signals/**:
    Did you classify every error case as a permanent error (SignalPermanentError, no retry) or a normal error (retryable)? Any case where the signal can't determine a score should be a SignalPermanentError.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@taobojlen, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 8 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: cba13496-c7cb-4fd5-9b40-7644b111de57

📥 Commits

Reviewing files that changed from the base of the PR and between 771e735 and 21ff76d.

📒 Files selected for processing (2)
  • client/src/webpages/dashboard/mrt/visualization/ManualReviewDashboardInsightsChart.test.ts
  • client/src/webpages/dashboard/mrt/visualization/ManualReviewDashboardInsightsChart.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@taobojlen
taobojlen force-pushed the fix/skipped-jobs-queue-grouping branch from 5615dbe to 2649198 Compare August 12, 2026 03:05
@taobojlen
taobojlen force-pushed the fix/manual-review-pie-legend branch from 50bfd31 to 2dec63b Compare August 12, 2026 03:06
@taobojlen
taobojlen force-pushed the fix/skipped-jobs-queue-grouping branch from 2649198 to 29d0db3 Compare August 12, 2026 03:42
@taobojlen
taobojlen force-pushed the fix/manual-review-pie-legend branch from 2dec63b to fbb32ab Compare August 12, 2026 03:42
Co-authored-by: Amp
Amp-Thread-ID: https://ampcode.com/threads/T-019fec69-19ab-77e8-b6f0-85af1ed67eed
Co-authored-by: Amp <amp@ampcode.com>
@taobojlen
taobojlen force-pushed the fix/manual-review-pie-legend branch from fbb32ab to 21ff76d Compare August 17, 2026 10:22
@taobojlen
taobojlen force-pushed the fix/skipped-jobs-queue-grouping branch from 29d0db3 to 4e65c4a Compare August 17, 2026 10:22
@taobojlen
taobojlen changed the base branch from fix/skipped-jobs-queue-grouping to main August 17, 2026 10:24
@taobojlen
taobojlen marked this pull request as ready for review August 18, 2026 13:35
@julietshen

Copy link
Copy Markdown
Member

I tested this locally and I get a stray 0 label when toggling off a segment, is that expected?

Screenshot 2026-08-18 at 10 38 38 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants