Skip to content

Make table sorting keyboard accessible - #1014

Open
taobojlen wants to merge 2 commits into
fix/merged-reports-sortingfrom
fix/table-sort-header-accessibility
Open

Make table sorting keyboard accessible#1014
taobojlen wants to merge 2 commits into
fix/merged-reports-sortingfrom
fix/table-sort-header-accessibility

Conversation

@taobojlen

@taobojlen taobojlen commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Context & Requests for Reviewers

This addresses a CodeRabbit comment from the @tanstack/react-table v9 upgrade. It was a pre-existing issue: our table sorting was not keyboard-accessible.

Tests

Manually tested. Example here:

CleanShot.2026-08-18.at.12.23.51.mp4

(Optional) Rollout Plan

N/A

Checklist

Only check items that apply to this PR; leave the rest unchecked.

  • If you changed anything user-facing (i.e. user interface or APIs):
    Did you update the CHANGELOG.md and related docs?

  • If you changed server/models/**/{ContentTypeModel,ActionModel,RuleModel,PolicyModel}.ts:
    Did you update the corresponding history tables and their triggers?

  • If you changed db/src/scripts/** and used CREATE TABLE, ADD COLUMN, or ALTER COLUMN:
    Are as many columns marked NOT NULL as possible? If some columns can sometimes be null depending on other columns, are there CHECK constraints capturing those relationships, and are these also reflected using unions in the associated Kysely types?

  • If you added a new signal in server/services/signalsService/signals/**:
    Did you classify every error case as a permanent error (SignalPermanentError, no retry) or a normal error (retryable)? Any case where the signal can't determine a score should be a SignalPermanentError.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5ab30067-3a47-4b1c-a95f-4ab59a989cf7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@taobojlen
taobojlen force-pushed the fix/table-sort-header-accessibility branch from eea8743 to d74baa7 Compare August 12, 2026 03:42
@taobojlen taobojlen changed the title fix/table sort header accessibility Make table sorting keyboard accessible Aug 12, 2026
@taobojlen
taobojlen force-pushed the fix/table-sort-header-accessibility branch from d74baa7 to ad0d785 Compare August 17, 2026 10:22
@taobojlen
taobojlen changed the base branch from fix/item-type-form-input-names to fix/merged-reports-sorting August 17, 2026 10:23
@taobojlen
taobojlen force-pushed the fix/table-sort-header-accessibility branch from ad0d785 to ccee8b8 Compare August 17, 2026 15:43
@taobojlen
taobojlen force-pushed the fix/table-sort-header-accessibility branch from ccee8b8 to 8320b88 Compare August 18, 2026 09:00
@taobojlen
taobojlen force-pushed the fix/table-sort-header-accessibility branch from 8320b88 to 582a2ff Compare August 18, 2026 09:25
@taobojlen taobojlen mentioned this pull request Aug 18, 2026
4 tasks
@taobojlen
taobojlen force-pushed the fix/table-sort-header-accessibility branch from 582a2ff to 474cd47 Compare August 18, 2026 10:00
@taobojlen
taobojlen force-pushed the fix/table-sort-header-accessibility branch 2 times, most recently from 45bbeb9 to f51fb31 Compare August 18, 2026 10:19
@taobojlen
taobojlen marked this pull request as ready for review August 18, 2026 11:25
@cassidyjames
cassidyjames requested a review from a team as a code owner August 21, 2026 15:26
@cassidyjames
cassidyjames force-pushed the fix/table-sort-header-accessibility branch from f51fb31 to 78e9232 Compare August 21, 2026 15:26
@cassidyjames
cassidyjames force-pushed the fix/table-sort-header-accessibility branch from 78e9232 to 434446c Compare August 21, 2026 15:33
@cassidyjames
cassidyjames force-pushed the fix/table-sort-header-accessibility branch from 434446c to e6b5a32 Compare August 21, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant