Skip to content

Fix investigation rule result selection - #998

Draft
taobojlen wants to merge 1 commit into
mainfrom
fix/investigation-selected-rule-result
Draft

Fix investigation rule result selection#998
taobojlen wants to merge 1 commit into
mainfrom
fix/investigation-selected-rule-result

Conversation

@taobojlen

Copy link
Copy Markdown
Contributor

Context & Requests for Reviewers

Tests

(Optional) Rollout Plan

Checklist

Only check items that apply to this PR; leave the rest unchecked.

  • If you changed anything user-facing (i.e. user interface or APIs):
    Did you update the CHANGELOG.md and related docs?

  • If you changed server/models/**/{ContentTypeModel,ActionModel,RuleModel,PolicyModel}.ts:
    Did you update the corresponding history tables and their triggers?

  • If you changed db/src/scripts/** and used CREATE TABLE, ADD COLUMN, or ALTER COLUMN:
    Are as many columns marked NOT NULL as possible? If some columns can sometimes be null depending on other columns, are there CHECK constraints capturing those relationships, and are these also reflected using unions in the associated Kysely types?

  • If you added a new signal in server/services/signalsService/signals/**:
    Did you classify every error case as a permanent error (SignalPermanentError, no retry) or a normal error (retryable)? Any case where the signal can't determine a score should be a SignalPermanentError.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 60174ee4-6679-4934-b722-1083c22802e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@taobojlen
taobojlen force-pushed the fix/report-rule-sample-details branch from a0762d3 to 5588369 Compare August 12, 2026 03:05
@taobojlen
taobojlen force-pushed the fix/investigation-selected-rule-result branch from 4aa9f98 to 7a4f379 Compare August 12, 2026 03:05
@taobojlen
taobojlen force-pushed the fix/report-rule-sample-details branch from 5588369 to c85c2bd Compare August 12, 2026 03:42
@taobojlen
taobojlen force-pushed the fix/investigation-selected-rule-result branch from 7a4f379 to 60cb43c Compare August 12, 2026 03:42
@taobojlen
taobojlen force-pushed the fix/report-rule-sample-details branch from c85c2bd to 71390df Compare August 17, 2026 10:22
@taobojlen
taobojlen force-pushed the fix/investigation-selected-rule-result branch from 60cb43c to 0a1b132 Compare August 17, 2026 10:22
@taobojlen
taobojlen changed the base branch from fix/report-rule-sample-details to main August 17, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant