Skip to content

Fix key prop warning - #999

Open
taobojlen wants to merge 2 commits into
mainfrom
fix/investigation-tag-key-warning
Open

Fix key prop warning#999
taobojlen wants to merge 2 commits into
mainfrom
fix/investigation-tag-key-warning

Conversation

@taobojlen

@taobojlen taobojlen commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Context & Requests for Reviewers

React returned a browser console warning because key is a reserved prop name. There's no need to pass it through like we were doing, it works fine without that.

Tests

Tested manually.

(Optional) Rollout Plan

N/A

Checklist

Only check items that apply to this PR; leave the rest unchecked.

  • If you changed anything user-facing (i.e. user interface or APIs):
    Did you update the CHANGELOG.md and related docs?

  • If you changed server/models/**/{ContentTypeModel,ActionModel,RuleModel,PolicyModel}.ts:
    Did you update the corresponding history tables and their triggers?

  • If you changed db/src/scripts/** and used CREATE TABLE, ADD COLUMN, or ALTER COLUMN:
    Are as many columns marked NOT NULL as possible? If some columns can sometimes be null depending on other columns, are there CHECK constraints capturing those relationships, and are these also reflected using unions in the associated Kysely types?

  • If you added a new signal in server/services/signalsService/signals/**:
    Did you classify every error case as a permanent error (SignalPermanentError, no retry) or a normal error (retryable)? Any case where the signal can't determine a score should be a SignalPermanentError.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@taobojlen, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dc424e8a-4557-4d68-95b4-097dac9adb6a

📥 Commits

Reviewing files that changed from the base of the PR and between 771e735 and 84feb53.

📒 Files selected for processing (1)
  • client/src/webpages/dashboard/investigation/InvestigationTag.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@taobojlen
taobojlen force-pushed the fix/investigation-selected-rule-result branch from 4aa9f98 to 7a4f379 Compare August 12, 2026 03:05
@taobojlen
taobojlen force-pushed the fix/investigation-tag-key-warning branch from 0d7bdb8 to a3f0d33 Compare August 12, 2026 03:05
@taobojlen
taobojlen force-pushed the fix/investigation-selected-rule-result branch from 7a4f379 to 60cb43c Compare August 12, 2026 03:42
@taobojlen
taobojlen force-pushed the fix/investigation-tag-key-warning branch from a3f0d33 to f8a018d Compare August 12, 2026 03:42
Co-Authored-By: Amp <amp@ampcode.com>

Amp-Thread-ID: https://ampcode.com/threads/T-019fec69-19ab-77e8-b6f0-85af1ed67eed
Co-authored-by: Amp <amp@ampcode.com>
@taobojlen
taobojlen force-pushed the fix/investigation-tag-key-warning branch from f8a018d to 1f9ef07 Compare August 17, 2026 10:22
@taobojlen
taobojlen force-pushed the fix/investigation-selected-rule-result branch from 60cb43c to 0a1b132 Compare August 17, 2026 10:22
@taobojlen
taobojlen changed the base branch from fix/investigation-selected-rule-result to main August 17, 2026 10:23
@taobojlen taobojlen changed the title Fix investigation tag key warning Fix key prop warning Aug 18, 2026
@taobojlen
taobojlen marked this pull request as ready for review August 18, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant