Bump grpcio to 1.82.1 - #415
Conversation
📝 WalkthroughWalkthroughThe common dependency group now pins ChangesDependency Version Update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collapses the platform_machine split (grpcio 1.49.1 on x86_64, 1.53.x elsewhere) into a single pin now that upstream ships wheels for both platforms again. Also bumps typing-extensions to 4.12.2, which grpcio 1.82.1 requires (>=4.12,<5).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pyproject.toml (1)
29-29: 🔒 Security & Privacy | 🔵 TrivialSurface the
grpciobump for license/CVE review
grpciomoves to1.82.1, butgrpcio-tools,grpcio-status,grpcio-health-checking, andgrpcio-reflectionare still pinned to older releases. Bring the full gRPC stack onto the same release train or review the mixed-version setup before merging.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pyproject.toml` at line 29, Update the gRPC dependency entries in pyproject.toml so grpcio, grpcio-tools, grpcio-status, grpcio-health-checking, and grpcio-reflection use the same 1.82.1 release, or explicitly review and document the mixed-version setup if those packages must remain older.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@pyproject.toml`:
- Line 29: Update the gRPC dependency entries in pyproject.toml so grpcio,
grpcio-tools, grpcio-status, grpcio-health-checking, and grpcio-reflection use
the same 1.82.1 release, or explicitly review and document the mixed-version
setup if those packages must remain older.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 291c8b81-cbf6-46c9-a0e0-f4eb3eb6524a
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
CHANGELOG.mdpyproject.toml
|
@haileyok Do you have strong thoughts on whether I should go ahead and bump protobufs from 4 -> 7, or just 4 -> 5 (which the PR does now). We use thrift at Meta, so I don't have any real world experience with protobuf major version jumps to draw on. |
|
@reitblatt i suspect the full bump is probably fine for protobuf...i wouldnt expect there to be anything very breaking (and i think the actual use of protobuf in here is relatively low though i may be mistaken) |
|
@cmttt im tagging you in this just as a heads up...i know we've gone back and forth on this a lot. i had claude a while back do a bit of work on figuring out what was up with the memory leak we were seeing, and it did successfully reproduce a leak in multiple grpc-io versions that we had previously attempted to upgrade to. that being said, im curious if you know anything about more recent protobuf versions we tested. claude eventually found that 1.74+ was actually fine, though it might not be the specific problem we were seeing? i think im pretty okay with us trying to get this in and see what happens, because its pretty unlikely we are going to uncover whether it works or not any other way...my understanding is the problems only reveal themselves after running for a bit of time and with enough scale. that being said, trying to use @julietshen's test kit might be of use here too though i'm not sure how to run it myself. |
|
@haileyok Honestly it's been awhile since I've tested grpc, but given that discord internal isn't using gevent anymore, I think you're good to go upgrading here. FWIW 1.52+ did work even with the old gevent worker, it just cut throughput massively. |
Collapses the platform_machine split (grpcio 1.49.1 on x86_64, 1.53.x elsewhere) into a single pin now that upstream ships wheels for both platforms again. Also bumps typing-extensions to 4.12.2, which grpcio 1.82.1 requires (>=4.12,<5).
Checklist
uv run ruff check .passes (no unused imports or other lint errors)uv tool run fawltydeps --check-unused --pyenv .venvpasses (no unused dependencies)CHANGELOG.mdwith my changes, if notable (refer to Keep a Changelog conventions)Summary by CodeRabbit