Skip to content

making the default method with no parameters supplied be a single type - #31

Open
rmflight wants to merge 1 commit into
ropensci:masterfrom
rmflight:single_method
Open

making the default method with no parameters supplied be a single type#31
rmflight wants to merge 1 commit into
ropensci:masterfrom
rmflight:single_method

Conversation

@rmflight

Copy link
Copy Markdown

If you don't specify the method when calling ocv_keypoints, it currently fails because there are multiple inputs to the switch statement

# this generates an error, when it really shouldn't
mona <- ocv_read('https://jeroen.github.io/images/monalisa.jpg')
mona <- ocv_resize(mona, width = 320, height = 477)
pts <- ocv_keypoints(mona, method = "FAST")

@jwijffels

Copy link
Copy Markdown
Contributor

Why not TYPE_9_16?

@rmflight

Copy link
Copy Markdown
Author

I truly just picked one. I'll be honest, I'm just a user, I haven't followed the literature in this space, I think I just picked the first one in the list to use. If there is a better default, then it should be used instead. I'm fine with changing the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants