Skip to content

Add Keep Alive property to background filter - #620

Open
men232 wants to merge 4 commits into
royshil:mainfrom
men232:main
Open

Add Keep Alive property to background filter#620
men232 wants to merge 4 commits into
royshil:mainfrom
men232:main

Conversation

@men232

@men232 men232 commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

This property ensures that the background filter remains active even when switching to another scene in OBS.

It is especially useful when you have a separate webcam scene with a background removal filter and use a source clone in another scene.

This property ensures that the background filter remains active even after switching to another scene in OBS
@royshil

royshil commented Apr 1, 2025

Copy link
Copy Markdown
Owner

@men232 can yo plz run clang-format on src/background-filter.cpp?

@umireon

umireon commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

Stalled?

@men232

men232 commented Nov 7, 2025

Copy link
Copy Markdown
Contributor Author

@royshil done, please review

@umireon

umireon commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

I suggest that this option should be inverted as "Stop filter when source is inactive" and having checked by default.
When this checkbox is off, this filter will continue processing even if the direct parent is not shown.
@royshil How do you think?

@royshil

royshil commented Nov 7, 2025

Copy link
Copy Markdown
Owner

Yes the inverse makes sense @umireon

@umireon umireon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invert the logic of keepalive property and name it in an easy-to-understand manner, please.

@umireon

umireon commented Nov 15, 2025

Copy link
Copy Markdown
Collaborator

Stalled?

@royshil
royshil requested a review from umireon November 19, 2025 20:01
@sobalap

sobalap commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

Is there anything that stalls the PR from being merged? I'd appreciate this feature being added, TIA

@umireon

umireon commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

@sobalap Can you take over this PR?

@sobalap

sobalap commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

Sure, I'll give it a try

@sobalap

sobalap commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

@umireon The changes are up on my fork https://github.com/sobalap/obs-backgroundremoval

@umireon

umireon commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

Feel free to open a PR at any time. I can help you to complete your PR 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants